Re: [PATCH RFC v2] Add /proc/pid/smaps_rollup

2017-08-28 Thread Michal Hocko
On Fri 25-08-17 14:16:37, Andrew Morton wrote: > On Thu, 24 Aug 2017 10:55:53 +0200 Michal Hocko wrote: > > > > If we assume that the number of VMAs is going to increase over time, > > > then doing anything we can do to reduce the overhead of each VMA > > > during PSS collection seems like the ri

Re: [PATCH RFC v2] Add /proc/pid/smaps_rollup

2017-08-25 Thread Andrew Morton
On Thu, 24 Aug 2017 10:55:53 +0200 Michal Hocko wrote: > > If we assume that the number of VMAs is going to increase over time, > > then doing anything we can do to reduce the overhead of each VMA > > during PSS collection seems like the right way to go, and that means > > outputting an aggregate

Re: [PATCH RFC v2] Add /proc/pid/smaps_rollup

2017-08-24 Thread Michal Hocko
Sorry for a late reply On Thu 10-08-17 12:17:07, Tim Murray wrote: > I've looked into this a fair bit on the Android side, so I can provide > some context. There are two main reasons why Android gathers PSS > information: > > 1. Android devices can show the user the amount of memory used per > ap

Re: [PATCH RFC v2] Add /proc/pid/smaps_rollup

2017-08-10 Thread Tim Murray
I've looked into this a fair bit on the Android side, so I can provide some context. There are two main reasons why Android gathers PSS information: 1. Android devices can show the user the amount of memory used per application via the settings app. This is a less important use case. 2. We log PSS

Re: [PATCH RFC v2] Add /proc/pid/smaps_rollup

2017-08-10 Thread Sonny Rao
On Thu, Aug 10, 2017 at 3:58 AM, Michal Hocko wrote: > On Thu 10-08-17 03:23:23, Daniel Colascione wrote: >> Thanks for taking a look at the patch! >> >> On Thu, Aug 10 2017, Michal Hocko wrote: >> > [CC linux-api - the patch was posted here >> > http://lkml.kernel.org/r/20170810001557.147285-1-da

Re: [PATCH RFC v2] Add /proc/pid/smaps_rollup

2017-08-10 Thread Michal Hocko
On Thu 10-08-17 03:23:23, Daniel Colascione wrote: > Thanks for taking a look at the patch! > > On Thu, Aug 10 2017, Michal Hocko wrote: > > [CC linux-api - the patch was posted here > > http://lkml.kernel.org/r/20170810001557.147285-1-dan...@google.com] > > > > On Thu 10-08-17 13:38:31, Minchan K

Re: [PATCH RFC v2] Add /proc/pid/smaps_rollup

2017-08-10 Thread Daniel Colascione
Thanks for taking a look at the patch! On Thu, Aug 10 2017, Michal Hocko wrote: > [CC linux-api - the patch was posted here > http://lkml.kernel.org/r/20170810001557.147285-1-dan...@google.com] > > On Thu 10-08-17 13:38:31, Minchan Kim wrote: >> On Wed, Aug 09, 2017 at 05:15:57PM -0700, Daniel Col

Re: [PATCH RFC v2] Add /proc/pid/smaps_rollup

2017-08-10 Thread Michal Hocko
[CC linux-api - the patch was posted here http://lkml.kernel.org/r/20170810001557.147285-1-dan...@google.com] On Thu 10-08-17 13:38:31, Minchan Kim wrote: > On Wed, Aug 09, 2017 at 05:15:57PM -0700, Daniel Colascione wrote: > > /proc/pid/smaps_rollup is a new proc file that improves the > > perfor

Re: [PATCH RFC v2] Add /proc/pid/smaps_rollup

2017-08-09 Thread Minchan Kim
On Wed, Aug 09, 2017 at 05:15:57PM -0700, Daniel Colascione wrote: > /proc/pid/smaps_rollup is a new proc file that improves the > performance of user programs that determine aggregate memory > statistics (e.g., total PSS) of a process. > > Android regularly "samples" the memory usage of various p

Re: [PATCH RFC v2] Add /proc/pid/smaps_rollup

2017-08-09 Thread Randy Dunlap
On 08/09/2017 05:15 PM, Daniel Colascione wrote: > > diff --git a/Documentation/ABI/testing/procfs-smaps_rollup > b/Documentation/ABI/testing/procfs-smaps_rollup > new file mode 100644 > index ..fd5a3699edf1 > --- /dev/null > +++ b/Documentation/ABI/testing/procfs-smaps_rollup > @@ -0