Re: [PATCH RFCv2 07/13] iommufd: Implement sw_msi support natively

2025-01-23 Thread Jason Gunthorpe
On Fri, Jan 10, 2025 at 07:32:23PM -0800, Nicolin Chen wrote: > +/* > + * FIXME: when a domain is removed any ids that are not in the union of > + * all still attached devices should be removed. > + */ I've been thinking about this, maybe we can just delete the comment. It is thinking about is t

Re: [PATCH RFCv2 07/13] iommufd: Implement sw_msi support natively

2025-01-16 Thread Jason Gunthorpe
On Tue, Jan 14, 2025 at 11:21:13PM -0500, Yury Norov wrote: > > +static int iommufd_sw_msi_install(struct iommufd_ctx *ictx, > > + struct iommufd_hwpt_paging *hwpt_paging, > > + struct iommufd_sw_msi_map *msi_map) > > +{ > > + unsigned long

Re: [PATCH RFCv2 07/13] iommufd: Implement sw_msi support natively

2025-01-14 Thread Yury Norov
On Fri, Jan 10, 2025 at 07:32:23PM -0800, Nicolin Chen wrote: > From: Jason Gunthorpe > > iommufd has a model where the iommu_domain can be changed while the VFIO > device is attached. In this case the MSI should continue to work. This > corner case has not worked because the dma-iommu implementa