Re: [PATCH RFT] regulator: pbias: Convert to use regmap helper functions

2014-03-09 Thread Mark Brown
On Fri, Mar 07, 2014 at 11:57:03PM +0800, Axel Lin wrote: > 2014-03-07 23:25 GMT+08:00 Balaji T K : > > The intention was to set vmode to 0 for any voltage request lesser than > > 1.8V. > This statement sounds wrong to me. > For example, If the request voltage range is 1.0V ~ 1.5V. > We should re

Re: [PATCH RFT] regulator: pbias: Convert to use regmap helper functions

2014-03-07 Thread Axel Lin
2014-03-07 23:25 GMT+08:00 Balaji T K : > On Thursday 06 March 2014 06:40 PM, Axel Lin wrote: >> >> This patch converts this driver to use the regmap helper functions >> provided by >> regulator core. >> >> This fixes a few issues in current implementation: >> >> 1) In original code, the set voltag

Re: [PATCH RFT] regulator: pbias: Convert to use regmap helper functions

2014-03-07 Thread Axel Lin
2014-03-06 23:20 GMT+08:00 Balaji T K : > On Thursday 06 March 2014 06:40 PM, Axel Lin wrote: >> >> This patch converts this driver to use the regmap helper functions >> provided by >> regulator core. >> >> This fixes a few issues in current implementation: >> >> 1) In original code, the set voltag

Re: [PATCH RFT] regulator: pbias: Convert to use regmap helper functions

2014-03-07 Thread Balaji T K
On Thursday 06 March 2014 06:40 PM, Axel Lin wrote: This patch converts this driver to use the regmap helper functions provided by regulator core. This fixes a few issues in current implementation: 1) In original code, the set voltage does not check max_uV, which means if request max_uV < 1

Re: [PATCH RFT] regulator: pbias: Convert to use regmap helper functions

2014-03-06 Thread Balaji T K
On Thursday 06 March 2014 06:40 PM, Axel Lin wrote: This patch converts this driver to use the regmap helper functions provided by regulator core. This fixes a few issues in current implementation: 1) In original code, the set voltage does not check max_uV, which means if request max_uV < 1