Re: [PATCH V10 07/10] efi: print unrecognized CPER section

2017-02-22 Thread James Morse
On 22/02/17 01:12, Russell King - ARM Linux wrote: > On Tue, Feb 21, 2017 at 07:10:11PM +, James Morse wrote: >> Hi Tyler, >> >> On 15/02/17 19:51, Tyler Baicar wrote: >>> + } else { >>> + const void *unknown_err; >>> + >>> + unknown_err = acpi_hest_generic_data_payload(gd

Re: [PATCH V10 07/10] efi: print unrecognized CPER section

2017-02-21 Thread Russell King - ARM Linux
On Tue, Feb 21, 2017 at 07:10:11PM +, James Morse wrote: > Hi Tyler, > > On 15/02/17 19:51, Tyler Baicar wrote: > > + } else { > > + const void *unknown_err; > > + > > + unknown_err = acpi_hest_generic_data_payload(gdata); > > + printk("%ssection type: %pUl\n",

Re: [PATCH V10 07/10] efi: print unrecognized CPER section

2017-02-21 Thread Joe Perches
On Tue, 2017-02-21 at 12:39 -0700, Baicar, Tyler wrote: > On 2/21/2017 12:10 PM, James Morse wrote: > > Nit: please use the "%s""section... that this file consistently uses. This > > means > > this code will still work as expected when someone adds '%ss' support to > > printk! Huh? How would th

Re: [PATCH V10 07/10] efi: print unrecognized CPER section

2017-02-21 Thread Baicar, Tyler
Hello James, On 2/21/2017 12:10 PM, James Morse wrote: Hi Tyler, On 15/02/17 19:51, Tyler Baicar wrote: UEFI spec allows for non-standard section in Common Platform Error Record. This is defined in section N.2.3 of UEFI version 2.5. Currently if the CPER section's type (UUID) does not match

Re: [PATCH V10 07/10] efi: print unrecognized CPER section

2017-02-21 Thread James Morse
Hi Tyler, On 15/02/17 19:51, Tyler Baicar wrote: > UEFI spec allows for non-standard section in Common Platform Error > Record. This is defined in section N.2.3 of UEFI version 2.5. > > Currently if the CPER section's type (UUID) does not match with > one of the section types that the kernel know

Re: [PATCH V10 07/10] efi: print unrecognized CPER section

2017-02-15 Thread Baicar, Tyler
Hello Joe, On 2/15/2017 1:07 PM, Joe Perches wrote: On Wed, 2017-02-15 at 12:51 -0700, Tyler Baicar wrote: UEFI spec allows for non-standard section in Common Platform Error Record. This is defined in section N.2.3 of UEFI version 2.5. Currently if the CPER section's type (UUID) does not matc

Re: [PATCH V10 07/10] efi: print unrecognized CPER section

2017-02-15 Thread Joe Perches
On Wed, 2017-02-15 at 12:51 -0700, Tyler Baicar wrote: > UEFI spec allows for non-standard section in Common Platform Error > Record. This is defined in section N.2.3 of UEFI version 2.5. > > Currently if the CPER section's type (UUID) does not match with > one of the section types that the kernel