Re: [PATCH V2] checkpatch: Warn on unnecessary void function return statements

2014-06-19 Thread Joe Perches
On Thu, 2014-06-19 at 13:18 -0700, Andrew Morton wrote: [] > Previous patch is now in mainline, so I did this: Swell, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kerne

Re: [PATCH V2] checkpatch: Warn on unnecessary void function return statements

2014-06-19 Thread Andrew Morton
On Wed, 18 Jun 2014 10:44:44 -0700 Joe Perches wrote: > With some exceptions, warn on void functions that end with a > "return;", because it's unnecessary. > > Check the closing brace at the start of a line. > If the line before that has a single tab, then return; > look at the line before that.

Re: [PATCH V2] checkpatch: Warn on unnecessary void function return statements

2014-06-18 Thread Anish Bhatt
On Wed 18 Jun 2014 10:44:44 AM PDT, Joe Perches wrote: > With some exceptions, warn on void functions that end with a > "return;", because it's unnecessary. > > Check the closing brace at the start of a line. > If the line before that has a single tab, then return; > look at the line before that.