Re: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

2013-04-15 Thread Viresh Kumar
On 14 April 2013 01:43, Francesco Lavra wrote: >> + for_each_child_of_node(of_find_node_by_path("/cpus"), np) { > > If of_find_node_by_path() returns NULL, there will be a NULL pointer > dereference. > >> + if (count++ != cpu_dev->id) >> + continue; >> +

Re: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

2013-04-13 Thread Francesco Lavra
On 03/26/2013 10:51 AM, Viresh Kumar wrote: > big LITTLE is ARM's new Architecture focussing power/performance needs of > modern > world. More information about big LITTLE can be found here: > > http://www.arm.com/products/processors/technologies/biglittleprocessing.php > http://lwn.net/Articles/

Re: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

2013-03-26 Thread Viresh Kumar
On 26 March 2013 18:47, Rob Herring wrote: > On 03/26/2013 04:51 AM, Viresh Kumar wrote: > I fail to see anything bL specific here. This is just multi-cluster, but > even for that I don't see anything new other than simply allowing per > cpu or per cluster opp's. The fact that we have one opp for

Re: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

2013-03-26 Thread Rob Herring
On 03/26/2013 04:51 AM, Viresh Kumar wrote: > big LITTLE is ARM's new Architecture focussing power/performance needs of > modern > world. More information about big LITTLE can be found here: > > http://www.arm.com/products/processors/technologies/biglittleprocessing.php > http://lwn.net/Articles/

Re: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

2013-03-21 Thread Viresh Kumar
On 22 March 2013 05:20, Rafael J. Wysocki wrote: > Please post a complete update patch if you want me to take it. I'd also would > like it to be ACKed by someone involved in the big-LITTLE work on the arch > side. Okay. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

2013-03-21 Thread Rafael J. Wysocki
On Monday, March 11, 2013 08:57:49 AM Viresh Kumar wrote: > On 10 March 2013 23:58, Francesco Lavra wrote: > > On 03/07/2013 06:14 PM, Viresh Kumar wrote: > >> +void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) > >> +{ > >> + if (arm_bL_ops != ops) { > >> + pr_info("%s: Re

Re: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

2013-03-10 Thread Viresh Kumar
On 10 March 2013 23:58, Francesco Lavra wrote: > On 03/07/2013 06:14 PM, Viresh Kumar wrote: >> +void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) >> +{ >> + if (arm_bL_ops != ops) { >> + pr_info("%s: Registered with: %s, can't unregister, exiting\n", >> +

Re: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

2013-03-10 Thread Francesco Lavra
Hi, On 03/07/2013 06:14 PM, Viresh Kumar wrote: > big LITTLE is ARM's new Architecture focussing power/performance needs of > modern > world. More information about big LITTLE can be found here: > > http://www.arm.com/products/processors/technologies/biglittleprocessing.php > http://lwn.net/Artic

Re: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

2013-03-08 Thread Viresh Kumar
On 8 March 2013 14:11, Guennadi Liakhovetski wrote: > Also in your driver you're doing > > cpufreq_notify_transition(&freqs, CPUFREQ_PRECHANGE); > ... > cpufreq_notify_transition(&freqs, CPUFREQ_POSTCHANGE); > > So, theoretically you could install su

Re: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

2013-03-07 Thread Guennadi Liakhovetski
Hi Viresh On Fri, 8 Mar 2013, Viresh Kumar wrote: > On 8 March 2013 05:56, Guennadi Liakhovetski wrote: > > I like generic drivers :) > > Me too :) > > > cpufreq-cpu0 is yet another such generic > > (cpufreq) driver. Now, comparing the functionality of the two: > > Great!! > > > we see, that

Re: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

2013-03-07 Thread Viresh Kumar
On 8 March 2013 05:56, Guennadi Liakhovetski wrote: > I like generic drivers :) Me too :) > cpufreq-cpu0 is yet another such generic > (cpufreq) driver. Now, comparing the functionality of the two: Great!! > we see, that this driver "only" switches CPU clock frequencies. Whereas > the cpufreq-

Re: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

2013-03-07 Thread Guennadi Liakhovetski
Hi Viresh On Fri, 8 Mar 2013, Viresh Kumar wrote: > big LITTLE is ARM's new Architecture focussing power/performance needs of > modern > world. More information about big LITTLE can be found here: > > http://www.arm.com/products/processors/technologies/biglittleprocessing.php > http://lwn.net/A