Re: [PATCH V2] mfd: abx500-core: Fix compiler warning larger stack frame

2014-05-22 Thread Lee Jones
> >> Inorder to report the kzalloc failure, I have just used a pr_debug > >> statement. If it looks ugly, should I change the function's return value > >> to int and give out an -ENOMEM ? > > > > Yes, please do that - and obviously add the checks to the calling code. > > But I cannot find any c

Re: [PATCH V2] mfd: abx500-core: Fix compiler warning larger stack frame

2014-05-21 Thread Jay Aurabind
On Wednesday 21 May 2014 02:47 PM, Lee Jones wrote: >> Change from V1 -> V2: Fix a potential null pointer dereference as reported >> by kbuild test robot . >> >> Inorder to report the kzalloc failure, I have just used a pr_debug >> statement. If it looks ugly, should I change the function's ret

Re: [PATCH V2] mfd: abx500-core: Fix compiler warning larger stack frame

2014-05-21 Thread Lee Jones
> Change from V1 -> V2: Fix a potential null pointer dereference as reported by > kbuild test robot . > > Inorder to report the kzalloc failure, I have just used a pr_debug statement. > If it looks ugly, should I change the function's return value to int and give > out an -ENOMEM ? Yes, please

Re: [PATCH V2] mfd: abx500-core: Fix compiler warning larger stack frame

2014-05-20 Thread Jay Aurabind
H1, Change from V1 -> V2: Fix a potential null pointer dereference as reported by kbuild test robot . Inorder to report the kzalloc failure, I have just used a pr_debug statement. If it looks ugly, should I change the function's return value to int and give out an -ENOMEM ? From 6615c7a995a6b