Re: [PATCH V2] nvme-pci: fix NULL pointer reference in nvme_alloc_ns

Hi Christoph Many thanks for your kindly response. On 01/04/2018 06:20 PM, Christoph Hellwig wrote: > This looks generally fine to me, ut a few nitpicks below: > >> - Based on Sagi's suggestion, add new state NVME_CTRL_ADMIN_LIVE. > > Maybe call this NVME_CTRL_ADMIN_ONLY ? Sound more in line

Re: [PATCH V2] nvme-pci: fix NULL pointer reference in nvme_alloc_ns

This looks generally fine to me, ut a few nitpicks below: > - Based on Sagi's suggestion, add new state NVME_CTRL_ADMIN_LIVE. Maybe call this NVME_CTRL_ADMIN_ONLY ? > - if (ctrl->state != NVME_CTRL_LIVE) > + if ((ctrl->state != NVME_CTRL_LIVE) && > + (ctrl->state != NVME_CTR