Re: [PATCH V2 10/11] coresight: sink: Add TRBE driver

2021-01-17 Thread Anshuman Khandual
On 1/15/21 6:13 PM, Suzuki K Poulose wrote: > On 1/15/21 5:29 AM, Anshuman Khandual wrote: >> >> >> On 1/13/21 8:58 PM, Suzuki K Poulose wrote: >>> Hi Anshuman, >>> >>> The driver looks overall good to me. Please find some minor comments below Sure. >>> >>> On 1/13/21 4:18 AM, Anshuman Khandua

Re: [PATCH V2 10/11] coresight: sink: Add TRBE driver

2021-01-15 Thread Suzuki K Poulose
On 1/15/21 5:29 AM, Anshuman Khandual wrote: On 1/13/21 8:58 PM, Suzuki K Poulose wrote: Hi Anshuman, The driver looks overall good to me. Please find some minor comments below On 1/13/21 4:18 AM, Anshuman Khandual wrote: Trace Buffer Extension (TRBE) implements a trace buffer per CPU which

Re: [PATCH V2 10/11] coresight: sink: Add TRBE driver

2021-01-14 Thread Anshuman Khandual
On 1/13/21 8:58 PM, Suzuki K Poulose wrote: > Hi Anshuman, > > The driver looks overall good to me. Please find some minor comments below > > On 1/13/21 4:18 AM, Anshuman Khandual wrote: >> Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is >> accessible via the system re

Re: [PATCH V2 10/11] coresight: sink: Add TRBE driver

2021-01-13 Thread Suzuki K Poulose
Hi Anshuman, The driver looks overall good to me. Please find some minor comments below On 1/13/21 4:18 AM, Anshuman Khandual wrote: Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is accessible via the system registers. The TRBE supports different addressing modes includi