Re: [PATCH V2 11/16] cpufreq: dt: Pass regulator name to the OPP core

2016-02-08 Thread Viresh Kumar
On 08-02-16, 14:55, Stephen Boyd wrote: > On 02/02, Viresh Kumar wrote: > > static int allocate_resources(int cpu, struct device **cdev, > > struct regulator **creg, struct clk **cclk) > > { > > @@ -200,6 +225,7 @@ static int cpufreq_init(struct cpufreq_policy *policy) >

Re: [PATCH V2 11/16] cpufreq: dt: Pass regulator name to the OPP core

2016-02-08 Thread Stephen Boyd
On 02/02, Viresh Kumar wrote: > static int allocate_resources(int cpu, struct device **cdev, > struct regulator **creg, struct clk **cclk) > { > @@ -200,6 +225,7 @@ static int cpufreq_init(struct cpufreq_policy *policy) > unsigned long min_uV = ~0, max_uV = 0; >

Re: [PATCH V2 11/16] cpufreq: dt: Pass regulator name to the OPP core

2016-02-01 Thread Viresh Kumar
On 01-02-16, 18:34, Stephen Boyd wrote: > On 01/28, Viresh Kumar wrote: > > + cpu_reg = regulator_get_optional(dev, reg); > > + ret = PTR_ERR_OR_ZERO(cpu_reg); > > + if (!ret) { > > + regulator_put(cpu_reg); > > What's the point of creating a regulator just to find the name? > It s

Re: [PATCH V2 11/16] cpufreq: dt: Pass regulator name to the OPP core

2016-02-01 Thread Stephen Boyd
On 01/28, Viresh Kumar wrote: > @@ -119,6 +120,49 @@ static int set_target(struct cpufreq_policy *policy, > unsigned int index) > return ret; > } > > +/* > + * An earlier version of opp-v1 bindings used to name the regulator > + * "cpu0-supply", we still need to handle that for backwards