Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-19 Thread Dave Chinner
On Mon, May 19, 2014 at 11:43:13AM +0200, Jan Kara wrote: > On Fri 16-05-14 10:11:56, Dave Chinner wrote: > > On Fri, May 16, 2014 at 01:19:09AM +0200, Mateusz Guzik wrote: > > > On Fri, May 16, 2014 at 08:51:41AM +1000, Dave Chinner wrote: > > > > On Fri, May 16, 2014 at 12:34:40AM +0200, Mateusz

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-19 Thread Jan Kara
On Fri 16-05-14 10:11:56, Dave Chinner wrote: > On Fri, May 16, 2014 at 01:19:09AM +0200, Mateusz Guzik wrote: > > On Fri, May 16, 2014 at 08:51:41AM +1000, Dave Chinner wrote: > > > On Fri, May 16, 2014 at 12:34:40AM +0200, Mateusz Guzik wrote: > > > > On Fri, May 16, 2014 at 08:21:35AM +1000, Dav

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-15 Thread Mateusz Guzik
On Fri, May 16, 2014 at 10:11:56AM +1000, Dave Chinner wrote: > On Fri, May 16, 2014 at 01:19:09AM +0200, Mateusz Guzik wrote: > > Except there is no log entry if /var got frozen (and this is not an > > imaginary example). > > Freezing the filesystem that the freezing daemon logs to is, well, a >

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-15 Thread Dave Chinner
On Fri, May 16, 2014 at 01:19:09AM +0200, Mateusz Guzik wrote: > On Fri, May 16, 2014 at 08:51:41AM +1000, Dave Chinner wrote: > > On Fri, May 16, 2014 at 12:34:40AM +0200, Mateusz Guzik wrote: > > > On Fri, May 16, 2014 at 08:21:35AM +1000, Dave Chinner wrote: > > > > > IOW, a new column in mounti

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-15 Thread Mateusz Guzik
On Fri, May 16, 2014 at 08:51:41AM +1000, Dave Chinner wrote: > On Fri, May 16, 2014 at 12:34:40AM +0200, Mateusz Guzik wrote: > > On Fri, May 16, 2014 at 08:21:35AM +1000, Dave Chinner wrote: > > > > IOW, a new column in mountinfo. For frozen filesystems it would contain > > > > 'frozen_by=[%s]:[%

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-15 Thread Dave Chinner
On Fri, May 16, 2014 at 12:34:40AM +0200, Mateusz Guzik wrote: > On Fri, May 16, 2014 at 08:21:35AM +1000, Dave Chinner wrote: > > > IOW, a new column in mountinfo. For frozen filesystems it would contain > > > 'frozen_by=[%s]:[%d]' (escaped comm, pid). > > > > I really don't see that the process

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-15 Thread Mateusz Guzik
; Date: Wed, 14 May 2014 17:40:22 -0500 > > > > From: Eric Sandeen > > > > Reply-To: sand...@redhat.com > > > > To: Dave Chinner , Jan Kara > > > > Cc: Mateusz Guzik , linux-kernel@vger.kernel.org, > > > > linux-fsde...@vger.kernel.or

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-15 Thread Dave Chinner
eply-To: sand...@redhat.com > > > To: Dave Chinner , Jan Kara > > > Cc: Mateusz Guzik , linux-kernel@vger.kernel.org, > > > linux-fsde...@vger.kernel.org, Josef Bacik , > > > Al Viro , Joe Perches > > > Subject: Re: [PATCH V2 2/2] fs: print a

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-15 Thread Dave Chinner
On Thu, May 15, 2014 at 12:13:56PM +0200, Jan Kara wrote: > On Thu 15-05-14 08:37:45, Dave Chinner wrote: > > On Thu, May 15, 2014 at 08:00:52AM +1000, Dave Chinner wrote: > > > On Wed, May 14, 2014 at 01:39:45PM +0200, Jan Kara wrote: > > > > On Wed 14-05-14 13:26:21, Mateusz Guzik wrote: > > > >

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-15 Thread Mateusz Guzik
Guzik , linux-kernel@vger.kernel.org, > > linux-fsde...@vger.kernel.org, Josef Bacik , > > Al Viro , Joe Perches > > Subject: Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing > > filesystems > > > > On 5/14/14, 5:37 PM, Dave Chinner w

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-15 Thread Lukáš Czerner
Al Viro , Joe Perches > Subject: Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing > filesystems > > On 5/14/14, 5:37 PM, Dave Chinner wrote: > > On Thu, May 15, 2014 at 08:00:52AM +1000, Dave Chinner wrote: > >> On Wed, May 14, 2014 at 01:39:45PM +0200

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-15 Thread Jan Kara
On Thu 15-05-14 08:37:45, Dave Chinner wrote: > On Thu, May 15, 2014 at 08:00:52AM +1000, Dave Chinner wrote: > > On Wed, May 14, 2014 at 01:39:45PM +0200, Jan Kara wrote: > > > On Wed 14-05-14 13:26:21, Mateusz Guzik wrote: > > > > On Wed, May 14, 2014 at 01:14:49PM +0200, Jan Kara wrote: > > > >

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-14 Thread Eric Sandeen
On 5/14/14, 5:37 PM, Dave Chinner wrote: > On Thu, May 15, 2014 at 08:00:52AM +1000, Dave Chinner wrote: >> On Wed, May 14, 2014 at 01:39:45PM +0200, Jan Kara wrote: >>> On Wed 14-05-14 13:26:21, Mateusz Guzik wrote: On Wed, May 14, 2014 at 01:14:49PM +0200, Jan Kara wrote: > On Wed 14-05-

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-14 Thread Dave Chinner
On Thu, May 15, 2014 at 08:00:52AM +1000, Dave Chinner wrote: > On Wed, May 14, 2014 at 01:39:45PM +0200, Jan Kara wrote: > > On Wed 14-05-14 13:26:21, Mateusz Guzik wrote: > > > On Wed, May 14, 2014 at 01:14:49PM +0200, Jan Kara wrote: > > > > On Wed 14-05-14 00:04:43, Mateusz Guzik wrote: > > > >

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-14 Thread Dave Chinner
On Wed, May 14, 2014 at 01:39:45PM +0200, Jan Kara wrote: > On Wed 14-05-14 13:26:21, Mateusz Guzik wrote: > > On Wed, May 14, 2014 at 01:14:49PM +0200, Jan Kara wrote: > > > On Wed 14-05-14 00:04:43, Mateusz Guzik wrote: > > > > This helps hang troubleshooting efforts when only dmesg is available.

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-14 Thread Lukáš Czerner
t: Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing > filesystems > > On Wed 14-05-14 00:04:43, Mateusz Guzik wrote: > > This helps hang troubleshooting efforts when only dmesg is available. > > > > While here remove code duplication with MS_RDONLY

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-14 Thread Jan Kara
On Wed 14-05-14 13:26:21, Mateusz Guzik wrote: > On Wed, May 14, 2014 at 01:14:49PM +0200, Jan Kara wrote: > > On Wed 14-05-14 00:04:43, Mateusz Guzik wrote: > > > This helps hang troubleshooting efforts when only dmesg is available. > > > > > > While here remove code duplication with MS_RDONLY ca

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-14 Thread Mateusz Guzik
On Wed, May 14, 2014 at 01:14:49PM +0200, Jan Kara wrote: > On Wed 14-05-14 00:04:43, Mateusz Guzik wrote: > > This helps hang troubleshooting efforts when only dmesg is available. > > > > While here remove code duplication with MS_RDONLY case and fix a > > whitespace nit. > I'm somewhat undecid

Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems

2014-05-14 Thread Jan Kara
On Wed 14-05-14 00:04:43, Mateusz Guzik wrote: > This helps hang troubleshooting efforts when only dmesg is available. > > While here remove code duplication with MS_RDONLY case and fix a > whitespace nit. I'm somewhat undecided here I have to say. On one hand I don't like printing to kernel log