Re: [PATCH V2 2/2] rpmsg: add syslog redirection driver

2019-02-16 Thread xiang xiao
On Fri, Feb 15, 2019 at 11:06 PM Andy Shevchenko wrote: > > On Fri, Feb 15, 2019 at 12:31:17AM +0800, xiang xiao wrote: > > On Thu, Feb 14, 2019 at 9:09 PM Andy Shevchenko > > wrote: > > > On Thu, Feb 14, 2019 at 02:02:38PM +0800, Xiang Xiao wrote: > > > > > This driver allows the remote processo

Re: [PATCH V2 2/2] rpmsg: add syslog redirection driver

2019-02-15 Thread Andy Shevchenko
On Fri, Feb 15, 2019 at 12:31:17AM +0800, xiang xiao wrote: > On Thu, Feb 14, 2019 at 9:09 PM Andy Shevchenko > wrote: > > On Thu, Feb 14, 2019 at 02:02:38PM +0800, Xiang Xiao wrote: > > > This driver allows the remote processor to redirect the output of > > > syslog or printf into the kernel log

Re: [PATCH V2 2/2] rpmsg: add syslog redirection driver

2019-02-14 Thread xiang xiao
On Thu, Feb 14, 2019 at 9:09 PM Andy Shevchenko wrote: > > On Thu, Feb 14, 2019 at 02:02:38PM +0800, Xiang Xiao wrote: > > From: Guiding Li > > > > This driver allows the remote processor to redirect the output of > > syslog or printf into the kernel log, which is very useful to see > > what happ

Re: [PATCH V2 2/2] rpmsg: add syslog redirection driver

2019-02-14 Thread Andy Shevchenko
On Thu, Feb 14, 2019 at 03:09:40PM +0200, Andy Shevchenko wrote: > On Thu, Feb 14, 2019 at 02:02:38PM +0800, Xiang Xiao wrote: > > + /* append the message after '\n' to the buffer */ > > > + if (copied != 0) { Missed comment if (copied) > > + } -- With Best Regards, Andy Shevchenko

Re: [PATCH V2 2/2] rpmsg: add syslog redirection driver

2019-02-14 Thread Andy Shevchenko
On Thu, Feb 14, 2019 at 02:02:38PM +0800, Xiang Xiao wrote: > From: Guiding Li > > This driver allows the remote processor to redirect the output of > syslog or printf into the kernel log, which is very useful to see > what happen in the remote side. > +struct rpmsg_syslog_header { > + u32