Re: [PATCH V3 1/3] mmc: sdhci: add support for using external DMA devices

2018-12-05 Thread Chunyan Zhang
On Tue, 4 Dec 2018 at 18:38, Faiz Abbas wrote: > > Hi, > > On 04/12/18 12:54 PM, Chunyan Zhang wrote: > > Some standard SD host controllers can support both external dma > > controllers as well as ADMA/SDMA in which the SD host controller > > acts as DMA master. TI's omap controller is the case as

Re: [PATCH V3 1/3] mmc: sdhci: add support for using external DMA devices

2018-12-04 Thread Faiz Abbas
Hi, On 04/12/18 12:54 PM, Chunyan Zhang wrote: > Some standard SD host controllers can support both external dma > controllers as well as ADMA/SDMA in which the SD host controller > acts as DMA master. TI's omap controller is the case as an example. > > Currently the generic SDHCI code supports A

Re: [PATCH V3 1/3] mmc: sdhci: add support for using external DMA devices

2018-12-03 Thread Chunyan Zhang
Hi Faiz, On Mon, 3 Dec 2018 at 21:55, Faiz Abbas wrote: > > Hi, > > On 03/12/18 5:45 PM, Faiz Abbas wrote: > > Hi, > > > >> +static void sdhci_external_dma_prepare_data(struct sdhci_host *host, > >> +struct mmc_command *cmd) > >> +{ > > > > Please add a con

Re: [PATCH V3 1/3] mmc: sdhci: add support for using external DMA devices

2018-12-03 Thread Faiz Abbas
Hi, On 03/12/18 5:45 PM, Faiz Abbas wrote: > Hi, > >> +static void sdhci_external_dma_prepare_data(struct sdhci_host *host, >> +struct mmc_command *cmd) >> +{ > > Please add a condition for data == NULL here. This was already pointed > out by Adrian in v2.

Re: [PATCH V3 1/3] mmc: sdhci: add support for using external DMA devices

2018-12-03 Thread Faiz Abbas
Hi, On 29/11/18 11:37 AM, Chunyan Zhang wrote: > Some standard SD host controllers can support both external dma > controllers as well as ADMA/SDMA in which the SD host controller > acts as DMA master. TI's omap controller is the case as an example. > > Currently the generic SDHCI code supports A

Re: [PATCH V3 1/3] mmc: sdhci: add support for using external DMA devices

2018-12-03 Thread Chunyan Zhang
On Mon, 3 Dec 2018 at 17:01, Faiz Abbas wrote: > > Hi Chunyan, > > On 29/11/18 2:53 PM, Adrian Hunter wrote: > > On 29/11/18 8:07 AM, Chunyan Zhang wrote: > >> Some standard SD host controllers can support both external dma > >> controllers as well as ADMA/SDMA in which the SD host controller > >>

Re: [PATCH V3 1/3] mmc: sdhci: add support for using external DMA devices

2018-12-03 Thread Faiz Abbas
Hi Chunyan, On 29/11/18 2:53 PM, Adrian Hunter wrote: > On 29/11/18 8:07 AM, Chunyan Zhang wrote: >> Some standard SD host controllers can support both external dma >> controllers as well as ADMA/SDMA in which the SD host controller >> acts as DMA master. TI's omap controller is the case as an exa

Re: [PATCH V3 1/3] mmc: sdhci: add support for using external DMA devices

2018-11-29 Thread Chunyan Zhang
On Thu, 29 Nov 2018 at 18:41, Adrian Hunter wrote: > > On 29/11/18 11:44 AM, Chunyan Zhang wrote: > > On Thu, 29 Nov 2018 at 17:25, Adrian Hunter wrote: > >> > >> On 29/11/18 8:07 AM, Chunyan Zhang wrote: > >>> Some standard SD host controllers can support both external dma > >>> controllers as w

Re: [PATCH V3 1/3] mmc: sdhci: add support for using external DMA devices

2018-11-29 Thread Adrian Hunter
On 29/11/18 11:44 AM, Chunyan Zhang wrote: > On Thu, 29 Nov 2018 at 17:25, Adrian Hunter wrote: >> >> On 29/11/18 8:07 AM, Chunyan Zhang wrote: >>> Some standard SD host controllers can support both external dma >>> controllers as well as ADMA/SDMA in which the SD host controller >>> acts as DMA m

Re: [PATCH V3 1/3] mmc: sdhci: add support for using external DMA devices

2018-11-29 Thread Chunyan Zhang
On Thu, 29 Nov 2018 at 17:25, Adrian Hunter wrote: > > On 29/11/18 8:07 AM, Chunyan Zhang wrote: > > Some standard SD host controllers can support both external dma > > controllers as well as ADMA/SDMA in which the SD host controller > > acts as DMA master. TI's omap controller is the case as an e

Re: [PATCH V3 1/3] mmc: sdhci: add support for using external DMA devices

2018-11-29 Thread Adrian Hunter
On 29/11/18 8:07 AM, Chunyan Zhang wrote: > Some standard SD host controllers can support both external dma > controllers as well as ADMA/SDMA in which the SD host controller > acts as DMA master. TI's omap controller is the case as an example. > > Currently the generic SDHCI code supports ADMA/SD