Re: [PATCH V4] PCI: handle CRS returned by device after FLR

2017-07-31 Thread Bjorn Helgaas
On Mon, Jul 31, 2017 at 05:45:46PM -0400, Sinan Kaya wrote: > Hi Bjorn, > > On 7/13/2017 7:49 PM, Bjorn Helgaas wrote: > > On Thu, Jul 06, 2017 at 05:07:14PM -0400, Sinan Kaya wrote: > >> An endpoint is allowed to issue Configuration Request Retry Status (CRS) > >> following a Function Level Reset

Re: [PATCH V4] PCI: handle CRS returned by device after FLR

2017-07-31 Thread Sinan Kaya
Hi Bjorn, On 7/13/2017 7:49 PM, Bjorn Helgaas wrote: > On Thu, Jul 06, 2017 at 05:07:14PM -0400, Sinan Kaya wrote: >> An endpoint is allowed to issue Configuration Request Retry Status (CRS) >> following a Function Level Reset (FLR) request to indicate that it is not >> ready to accept new request

Re: [PATCH V4] PCI: handle CRS returned by device after FLR

2017-07-14 Thread Sinan Kaya
Hi Bjorn, On 7/13/2017 7:49 PM, Bjorn Helgaas wrote: > How VFs report vendor ID is irrelevant. I was trying to highlight this. "SR-IOV spec rev 1.1, 3.4.1.1 & 3.4.1.2, Vendor ID and Device ID fields for the VF return 0x when read. The "Virtualization Intermediary" is supposed to use the ve

Re: [PATCH V4] PCI: handle CRS returned by device after FLR

2017-07-14 Thread Sinan Kaya
On 7/13/2017 7:38 PM, Bjorn Helgaas wrote: >> This does not specify a hard limit above on how long SW need to wait. > I wouldn't expect a *maximum* time we can wait. I'm looking for the > minimum times the spec requires. My understanding is FLR needs to finish in 100ms max under normal circumsta

Re: [PATCH V4] PCI: handle CRS returned by device after FLR

2017-07-13 Thread Bjorn Helgaas
On Thu, Jul 06, 2017 at 05:07:14PM -0400, Sinan Kaya wrote: > An endpoint is allowed to issue Configuration Request Retry Status (CRS) > following a Function Level Reset (FLR) request to indicate that it is not > ready to accept new requests. > > Seen a timeout message with Intel 750 NVMe drive an

Re: [PATCH V4] PCI: handle CRS returned by device after FLR

2017-07-13 Thread Bjorn Helgaas
On Thu, Jul 13, 2017 at 11:44:12AM -0400, Sinan Kaya wrote: > On 7/13/2017 8:17 AM, Bjorn Helgaas wrote: > >> he spec is calling to wait up to 1 seconds if the device is sending CRS. > >> The NVMe device seems to be requiring more. Relax this up to 60 seconds. > > Can you add a pointer to the "1 se

Re: [PATCH V4] PCI: handle CRS returned by device after FLR

2017-07-13 Thread Keith Busch
On Thu, Jul 13, 2017 at 12:42:44PM -0400, Sinan Kaya wrote: > On 7/13/2017 12:29 PM, Keith Busch wrote: > > That wording is just confusing. It looks to me the 1 second polling is > > to be used following a reset if CRS is not implemented. > > > > > > https://pcisig.com/sites/default/files/speci

Re: [PATCH V4] PCI: handle CRS returned by device after FLR

2017-07-13 Thread Sinan Kaya
On 7/13/2017 12:29 PM, Keith Busch wrote: >> When used, DRS and FRS allow an improved behavior over the CRS mechanism, >> and eliminate >> its associated periodic polling time of up to 1 second following a reset." > That wording is just confusing. It looks to me the 1 second polling is > to be use

Re: [PATCH V4] PCI: handle CRS returned by device after FLR

2017-07-13 Thread Keith Busch
On Thu, Jul 13, 2017 at 11:44:12AM -0400, Sinan Kaya wrote: > On 7/13/2017 8:17 AM, Bjorn Helgaas wrote: > >> he spec is calling to wait up to 1 seconds if the device is sending CRS. > >> The NVMe device seems to be requiring more. Relax this up to 60 seconds. > > Can you add a pointer to the "1 se

Re: [PATCH V4] PCI: handle CRS returned by device after FLR

2017-07-13 Thread Keith Busch
On Thu, Jul 13, 2017 at 07:17:58AM -0500, Bjorn Helgaas wrote: > On Thu, Jul 06, 2017 at 05:07:14PM -0400, Sinan Kaya wrote: > > An endpoint is allowed to issue Configuration Request Retry Status (CRS) > > following a Function Level Reset (FLR) request to indicate that it is not > > ready to accept

Re: [PATCH V4] PCI: handle CRS returned by device after FLR

2017-07-13 Thread Sinan Kaya
On 7/13/2017 8:17 AM, Bjorn Helgaas wrote: >> he spec is calling to wait up to 1 seconds if the device is sending CRS. >> The NVMe device seems to be requiring more. Relax this up to 60 seconds. > Can you add a pointer to the "1 second" requirement in the spec here? > We use 60 seconds in pci_scan_

Re: [PATCH V4] PCI: handle CRS returned by device after FLR

2017-07-13 Thread Bjorn Helgaas
On Thu, Jul 06, 2017 at 05:07:14PM -0400, Sinan Kaya wrote: > An endpoint is allowed to issue Configuration Request Retry Status (CRS) > following a Function Level Reset (FLR) request to indicate that it is not > ready to accept new requests. > > Seen a timeout message with Intel 750 NVMe drive an