Re: [PATCH V4 09/11] soc: mediatek: PMIC wrap: add a slave specific struct

2016-02-01 Thread Henry Chen
On Mon, 2016-02-01 at 09:25 +0100, John Crispin wrote: > > On 28/01/2016 03:37, Henry Chen wrote: > > Hi John, > > > > On Wed, 2016-01-27 at 12:29 +0100, John Crispin wrote: > > > >> @@ -746,7 +786,7 @@ static int pwrap_init(struct pmic_wrapper *wrp) > >>pwrap_writel(wrp, 1, PWRAP_DIO_EN); >

Re: [PATCH V4 09/11] soc: mediatek: PMIC wrap: add a slave specific struct

2016-02-01 Thread John Crispin
On 28/01/2016 03:37, Henry Chen wrote: > Hi John, > > On Wed, 2016-01-27 at 12:29 +0100, John Crispin wrote: > >> @@ -746,7 +786,7 @@ static int pwrap_init(struct pmic_wrapper *wrp) >> pwrap_writel(wrp, 1, PWRAP_DIO_EN); >> >> /* Read Test */ >> -pwrap_read(wrp, PWRAP_DEW_READ_T

Re: [PATCH V4 09/11] soc: mediatek: PMIC wrap: add a slave specific struct

2016-01-27 Thread Henry Chen
Hi John, On Wed, 2016-01-27 at 12:29 +0100, John Crispin wrote: > @@ -746,7 +786,7 @@ static int pwrap_init(struct pmic_wrapper *wrp) > pwrap_writel(wrp, 1, PWRAP_DIO_EN); > > /* Read Test */ > - pwrap_read(wrp, PWRAP_DEW_READ_TEST, &rdata); > + pwrap_dew_read(wrp, PWRAP_DEW