Re: [PATCH V4 3/5] clk: imx: Support building i.MX common clock driver as module

2020-07-02 Thread Arnd Bergmann
On Thu, Jul 2, 2020 at 9:12 AM Anson Huang wrote: > > > > The question is whether the #ifdef check in the header to test for MODULE > > (only calling it if this particular soc has a built-in clk driver, which is > > sufficient) > > or for IS_MODULE(CONFIG_MXC_CLK) (call it if _any_ clk driver is

RE: [PATCH V4 3/5] clk: imx: Support building i.MX common clock driver as module

2020-07-02 Thread Anson Huang
Hi, Arnd > Subject: Re: [PATCH V4 3/5] clk: imx: Support building i.MX common clock > driver as module > > On Thu, Jul 2, 2020 at 8:40 AM Dong Aisheng wrote: > > On Thu, Jul 2, 2020 at 2:11 PM Anson Huang > wrote: > > > > Subject: Re: [PATCH V4 3/5] clk:

Re: [PATCH V4 3/5] clk: imx: Support building i.MX common clock driver as module

2020-07-02 Thread Arnd Bergmann
On Thu, Jul 2, 2020 at 8:40 AM Dong Aisheng wrote: > On Thu, Jul 2, 2020 at 2:11 PM Anson Huang wrote: > > > Subject: Re: [PATCH V4 3/5] clk: imx: Support building i.MX common clock > > > > I am fine of adding the '#ifndef MODULE' to imx_clk_disable_uart() and > > imx_keep_uart_clocks_param() >

RE: [PATCH V4 3/5] clk: imx: Support building i.MX common clock driver as module

2020-07-01 Thread Anson Huang
> Subject: Re: [PATCH V4 3/5] clk: imx: Support building i.MX common clock > driver as module > > On Thu, Jul 2, 2020 at 2:11 PM Anson Huang wrote: > > > > > Subject: Re: [PATCH V4 3/5] clk: imx: Support building i.MX common > > > clock driver as module >

Re: [PATCH V4 3/5] clk: imx: Support building i.MX common clock driver as module

2020-07-01 Thread Dong Aisheng
On Thu, Jul 2, 2020 at 2:11 PM Anson Huang wrote: > > > Subject: Re: [PATCH V4 3/5] clk: imx: Support building i.MX common clock > > driver as module > > > > On Thu, Jul 2, 2020 at 11:26 AM Anson Huang > > wrote: > > [...] > > > > > @@ -143

RE: [PATCH V4 3/5] clk: imx: Support building i.MX common clock driver as module

2020-07-01 Thread Anson Huang
> Subject: Re: [PATCH V4 3/5] clk: imx: Support building i.MX common clock > driver as module > > On Thu, Jul 2, 2020 at 11:26 AM Anson Huang > wrote: > [...] > > > > @@ -143,16 +148,18 @@ void imx_cscmr1_fixup(u32 *val) static int > > > > imx_kee

Re: [PATCH V4 3/5] clk: imx: Support building i.MX common clock driver as module

2020-07-01 Thread Dong Aisheng
On Thu, Jul 2, 2020 at 11:26 AM Anson Huang wrote: [...] > > > @@ -143,16 +148,18 @@ void imx_cscmr1_fixup(u32 *val) > > > static int imx_keep_uart_clocks; > > > static struct clk ** const *imx_uart_clocks; > > > > > > -static int __init imx_keep_uart_clocks_param(char *str) > > > +static int __

RE: [PATCH V4 3/5] clk: imx: Support building i.MX common clock driver as module

2020-07-01 Thread Anson Huang
> Subject: Re: [PATCH V4 3/5] clk: imx: Support building i.MX common clock > driver as module > > On Thu, Jul 2, 2020 at 10:19 AM Anson Huang > wrote: > > > > There are more and more requirements of building SoC specific drivers > > as modules, add support for

Re: [PATCH V4 3/5] clk: imx: Support building i.MX common clock driver as module

2020-07-01 Thread Dong Aisheng
On Thu, Jul 2, 2020 at 10:19 AM Anson Huang wrote: > > There are more and more requirements of building SoC specific drivers > as modules, add support for building i.MX common clock driver as module > to meet the requirement. > > Signed-off-by: Anson Huang > --- > Changes since V3: > - ON