Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback

2017-12-08 Thread Sinan Kaya
On 12/8/2017 9:33 AM, Sinan Kaya wrote: > On 12/8/2017 4:11 AM, Lothar Waßmann wrote: >>> While implementing the ACPI piece, I have to convert an unsigned long to >>> (const void *) in ACPI code so that the APIs are compatible. >>> >> Just one more remark: Do you need write access to the data the p

Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback

2017-12-08 Thread Sinan Kaya
On 12/8/2017 4:11 AM, Lothar Waßmann wrote: >> While implementing the ACPI piece, I have to convert an unsigned long to >> (const void *) in ACPI code so that the APIs are compatible. >> > Just one more remark: Do you need write access to the data the pointer > returned by device_get_match_data() o

Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback

2017-12-08 Thread Lothar Waßmann
Hi, On Thu, 7 Dec 2017 12:50:50 -0500 Sinan Kaya wrote: > On 12/7/2017 10:20 AM, Lothar Waßmann wrote: > > Hi, > > > > On Thu, 7 Dec 2017 09:45:31 -0500 Sinan Kaya wrote: > >> On 12/7/2017 8:10 AM, Lothar Waßmann wrote: > +void *of_fwnode_get_match_data(const struct fwnode_handle *fwnode, >

Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback

2017-12-08 Thread Lothar Waßmann
Hi, On Thu, 7 Dec 2017 12:50:50 -0500 Sinan Kaya wrote: > On 12/7/2017 10:20 AM, Lothar Waßmann wrote: > > Hi, > > > > On Thu, 7 Dec 2017 09:45:31 -0500 Sinan Kaya wrote: > >> On 12/7/2017 8:10 AM, Lothar Waßmann wrote: > +void *of_fwnode_get_match_data(const struct fwnode_handle *fwnode, >

Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback

2017-12-07 Thread Sinan Kaya
On 12/7/2017 10:20 AM, Lothar Waßmann wrote: > Hi, > > On Thu, 7 Dec 2017 09:45:31 -0500 Sinan Kaya wrote: >> On 12/7/2017 8:10 AM, Lothar Waßmann wrote: +void *of_fwnode_get_match_data(const struct fwnode_handle *fwnode, + struct device *dev) >>> Shouldn't this b

Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback

2017-12-07 Thread Lothar Waßmann
Hi, On Thu, 7 Dec 2017 09:45:31 -0500 Sinan Kaya wrote: > On 12/7/2017 8:10 AM, Lothar Waßmann wrote: > >> +void *of_fwnode_get_match_data(const struct fwnode_handle *fwnode, > >> + struct device *dev) > > Shouldn't this be 'const void *of_fwnode_get_match_data > > OF keep

Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback

2017-12-07 Thread Sinan Kaya
On 12/7/2017 8:10 AM, Lothar Waßmann wrote: >> +void *of_fwnode_get_match_data(const struct fwnode_handle *fwnode, >> + struct device *dev) > Shouldn't this be 'const void *of_fwnode_get_match_data OF keeps the driver data as a (const void*) internally. ACPI keeps the dri

Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback

2017-12-07 Thread Lothar Waßmann
Hi, On Tue, 5 Dec 2017 12:04:49 -0500 Sinan Kaya wrote: > Now that we have a get_match_data() callback as part of the firmware node, > implement the OF specific piece for it. > > Signed-off-by: Sinan Kaya > --- > drivers/of/property.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --

Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback

2017-12-07 Thread Sakari Ailus
Hi Sinan, On Tue, Dec 05, 2017 at 12:04:49PM -0500, Sinan Kaya wrote: > Now that we have a get_match_data() callback as part of the firmware node, > implement the OF specific piece for it. > > Signed-off-by: Sinan Kaya > --- > drivers/of/property.c | 7 +++ > 1 file changed, 7 insertions(+)

Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback

2017-12-05 Thread Rob Herring
On Tue, Dec 5, 2017 at 11:04 AM, Sinan Kaya wrote: > Now that we have a get_match_data() callback as part of the firmware node, > implement the OF specific piece for it. > > Signed-off-by: Sinan Kaya > --- > drivers/of/property.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/dr