Re: [PATCH V6 5/5] remoteproc: qcom: Add q6v5-wcss rproc ops

2018-05-22 Thread Sricharan R
Hi, On 5/18/2018 5:59 PM, Vinod wrote: > On 14-05-18, 16:16, Sricharan R wrote: > >> +static int q6v5_wcss_start(struct rproc *rproc) >> +{ >> +struct q6v5 *qproc = rproc->priv; >> +int ret = 0; > > Superfluous initialization > ok. >> + >> +ret = q6v5_clk_enable(qproc->dev, qproc

Re: [PATCH V6 5/5] remoteproc: qcom: Add q6v5-wcss rproc ops

2018-05-18 Thread Vinod
On 14-05-18, 16:16, Sricharan R wrote: > +static int q6v5_wcss_start(struct rproc *rproc) > +{ > + struct q6v5 *qproc = rproc->priv; > + int ret = 0; Superfluous initialization > + > + ret = q6v5_clk_enable(qproc->dev, qproc->active_clks, > + qproc->active_c