Re: [PATCH V7 3/6] block: pass flags to blk_queue_enter()

2017-10-03 Thread Ming Lei
On Mon, Oct 02, 2017 at 06:40:32AM -0700, Christoph Hellwig wrote: > On Sat, Sep 30, 2017 at 02:12:11PM +0800, Ming Lei wrote: > > We need to pass PREEMPT flags to blk_queue_enter() > > for allocating request with RQF_PREEMPT in the > > following patch. > > I don't like having another name space f

Re: [PATCH V7 3/6] block: pass flags to blk_queue_enter()

2017-10-02 Thread Christoph Hellwig
On Sat, Sep 30, 2017 at 02:12:11PM +0800, Ming Lei wrote: > We need to pass PREEMPT flags to blk_queue_enter() > for allocating request with RQF_PREEMPT in the > following patch. I don't like having another name space for flags. It seems like we should simply pass ops on, and then map the nowait