Re: [PATCH bpf-next v6 4/5] bpf: verifier: Support eliding map lookup nullness

On Thu, Jan 02, 2025 at 06:53:54PM -0800, Eduard Zingerman wrote: > On Thu, 2024-12-19 at 21:09 -0700, Daniel Xu wrote: > > lgtm, but please see a note below. > > [...] > > > +/* Returns constant key value if possible, else negative error */ > > +static s64 get_constant_map_key(struct bpf_verifi

Re: [PATCH bpf-next v6 4/5] bpf: verifier: Support eliding map lookup nullness

On Thu, 2024-12-19 at 21:09 -0700, Daniel Xu wrote: lgtm, but please see a note below. [...] > +/* Returns constant key value if possible, else negative error */ > +static s64 get_constant_map_key(struct bpf_verifier_env *env, > + struct bpf_reg_state *key, > +