Re: [PATCH for 4.4-stable] KVM: x86: fix singlestepping over syscall

2017-11-20 Thread Paolo Bonzini
On 20/11/2017 10:55, David Hildenbrand wrote: > This looks good to me. > > General question: how do we treat KVM single stepping and concurrent TF > in the guest? IOW, shouldn't the "else" rather be a check for ctxt->tf ? > (or is that handled later on e.g. in user space?) At this time, not very

Re: [PATCH for 4.4-stable] KVM: x86: fix singlestepping over syscall

2017-11-20 Thread David Hildenbrand
On 16.11.2017 19:07, Paolo Bonzini wrote: > [ Upstream commit c8401dda2f0a00cd25c0af6a95ed50e478d25de4 ] > > TF is handled a bit differently for syscall and sysret, compared > to the other instructions: TF is checked after the instruction completes, > so that the OS can disable #DB at a syscall by