Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

2017-05-25 Thread David Miller
From: Peter Dawson Date: Fri, 26 May 2017 06:08:42 +1000 > On Thu, 25 May 2017 15:49:14 -0400 (EDT) > David Miller wrote: > >> Still not correct, you need to use a "Fixes: " tag of the form: >> >> Fixes: 90427ef5d2a4 ("ipv6: fix flow labels when the traffic class is non-0") >> >> And it must

Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

2017-05-25 Thread Peter Dawson
On Thu, 25 May 2017 15:49:14 -0400 (EDT) David Miller wrote: > Still not correct, you need to use a "Fixes: " tag of the form: > > Fixes: 90427ef5d2a4 ("ipv6: fix flow labels when the traffic class is non-0") > > And it must appear of the first line of tags, before signoffs and acks, > with no

Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

2017-05-25 Thread David Miller
From: Peter Dawson Date: Fri, 26 May 2017 05:46:27 +1000 > On Thu, 25 May 2017 12:11:17 -0400 (EDT) > David Miller wrote: > >> > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=195661 >> >> This is not the correct way to use the Fixes: tag. >> >> You should specify the commit that introd

Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

2017-05-25 Thread Peter Dawson
On Thu, 25 May 2017 12:11:17 -0400 (EDT) David Miller wrote: > > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=195661 > > This is not the correct way to use the Fixes: tag. > > You should specify the commit that introduced the regression > between 4.9.x and 4.10.x, and that you are fixin

Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

2017-05-25 Thread David Miller
From: Peter Dawson Date: Tue, 23 May 2017 14:36:16 +1000 > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=195661 This is not the correct way to use the Fixes: tag. You should specify the commit that introduced the regression between 4.9.x and 4.10.x, and that you are fixing here. The corre