Re: [PATCH net-next] net: fix up truesize of cloned skb in skb_prepare_for_shift()

2021-02-02 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 1 Feb 2021 17:04:20 +0100 you wrote: > Avoid the assumption that ksize(kmalloc(S)) == ksize(kmalloc(S)): when > cloning an skb, save and restore truesize after pskb_expand_head(). This > can occur if the allocator

Re: [PATCH net-next] net: fix up truesize of cloned skb in skb_prepare_for_shift()

2021-02-02 Thread Marco Elver
On Tue, 2 Feb 2021 at 18:59, Eric Dumazet wrote: > > On Mon, Feb 1, 2021 at 5:04 PM Marco Elver wrote: > > > > Avoid the assumption that ksize(kmalloc(S)) == ksize(kmalloc(S)): when > > cloning an skb, save and restore truesize after pskb_expand_head(). This > > can occur if the allocator decides

Re: [PATCH net-next] net: fix up truesize of cloned skb in skb_prepare_for_shift()

2021-02-02 Thread Eric Dumazet
On Mon, Feb 1, 2021 at 5:04 PM Marco Elver wrote: > > Avoid the assumption that ksize(kmalloc(S)) == ksize(kmalloc(S)): when > cloning an skb, save and restore truesize after pskb_expand_head(). This > can occur if the allocator decides to service an allocation of the same > size differently (e.g.

Re: [PATCH net-next] net: fix up truesize of cloned skb in skb_prepare_for_shift()

2021-02-02 Thread Christoph Paasch
On Mon, Feb 1, 2021 at 9:58 AM Eric Dumazet wrote: > > On Mon, Feb 1, 2021 at 6:34 PM Marco Elver wrote: > > > > On Mon, 1 Feb 2021 at 17:50, Christoph Paasch > > > > just a few days ago we found out that this also fixes a syzkaller > > > issue on MPTCP > > > (https://github.com/multipath-tcp/mp

Re: [PATCH net-next] net: fix up truesize of cloned skb in skb_prepare_for_shift()

2021-02-01 Thread Eric Dumazet
On Mon, Feb 1, 2021 at 6:34 PM Marco Elver wrote: > > On Mon, 1 Feb 2021 at 17:50, Christoph Paasch > > just a few days ago we found out that this also fixes a syzkaller > > issue on MPTCP (https://github.com/multipath-tcp/mptcp_net-next/issues/136). > > I confirmed that this patch fixes the issu

Re: [PATCH net-next] net: fix up truesize of cloned skb in skb_prepare_for_shift()

2021-02-01 Thread Marco Elver
On Mon, 1 Feb 2021 at 17:50, Christoph Paasch wrote: > On Mon, Feb 1, 2021 at 8:09 AM Marco Elver wrote: > > > > Avoid the assumption that ksize(kmalloc(S)) == ksize(kmalloc(S)): when > > cloning an skb, save and restore truesize after pskb_expand_head(). This > > can occur if the allocator decid

Re: [PATCH net-next] net: fix up truesize of cloned skb in skb_prepare_for_shift()

2021-02-01 Thread Christoph Paasch
On Mon, Feb 1, 2021 at 8:09 AM Marco Elver wrote: > > Avoid the assumption that ksize(kmalloc(S)) == ksize(kmalloc(S)): when > cloning an skb, save and restore truesize after pskb_expand_head(). This > can occur if the allocator decides to service an allocation of the same > size differently (e.g.