Re: [PATCH net-next] net: mvpp2: phylink support

2017-10-09 Thread Russell King - ARM Linux
On Mon, Oct 09, 2017 at 02:55:27PM +0200, Antoine Tenart wrote: > Hi Russell, > > On Mon, Sep 25, 2017 at 11:55:14AM +0200, Antoine Tenart wrote: > > On Fri, Sep 22, 2017 at 12:07:31PM +0100, Russell King - ARM Linux wrote: > > > On Thu, Sep 21, 2017 at 03:45:22PM +0200, Antoine Tenart wrote: > >

Re: [PATCH net-next] net: mvpp2: phylink support

2017-10-09 Thread Antoine Tenart
Hi Russell, On Mon, Sep 25, 2017 at 11:55:14AM +0200, Antoine Tenart wrote: > On Fri, Sep 22, 2017 at 12:07:31PM +0100, Russell King - ARM Linux wrote: > > On Thu, Sep 21, 2017 at 03:45:22PM +0200, Antoine Tenart wrote: > > > > +static int mvpp2_phylink_mac_link_state(struct net_device *dev, > >

Re: [PATCH net-next] net: mvpp2: phylink support

2017-09-25 Thread Antoine Tenart
On Mon, Sep 25, 2017 at 01:13:43PM +0100, Russell King - ARM Linux wrote: > On Mon, Sep 25, 2017 at 01:53:03PM +0200, Antoine Tenart wrote: > > On Mon, Sep 25, 2017 at 11:45:32AM +0100, Russell King - ARM Linux wrote: > > > Can you describe what the GoP link IRQ is doing please? > > > > In cases w

Re: [PATCH net-next] net: mvpp2: phylink support

2017-09-25 Thread Russell King - ARM Linux
On Mon, Sep 25, 2017 at 01:53:03PM +0200, Antoine Tenart wrote: > On Mon, Sep 25, 2017 at 11:45:32AM +0100, Russell King - ARM Linux wrote: > > Can you describe what the GoP link IRQ is doing please? > > In cases where there is no PHY connected to the MAC and no SFP cage is > used. One example is

Re: [PATCH net-next] net: mvpp2: phylink support

2017-09-25 Thread Antoine Tenart
On Mon, Sep 25, 2017 at 11:45:32AM +0100, Russell King - ARM Linux wrote: > On Mon, Sep 25, 2017 at 11:55:14AM +0200, Antoine Tenart wrote: > > On Fri, Sep 22, 2017 at 12:07:31PM +0100, Russell King - ARM Linux wrote: > > > On Thu, Sep 21, 2017 at 03:45:22PM +0200, Antoine Tenart wrote: > > > > Con

Re: [PATCH net-next] net: mvpp2: phylink support

2017-09-25 Thread Russell King - ARM Linux
On Mon, Sep 25, 2017 at 11:55:14AM +0200, Antoine Tenart wrote: > Hi Russell, > > On Fri, Sep 22, 2017 at 12:07:31PM +0100, Russell King - ARM Linux wrote: > > On Thu, Sep 21, 2017 at 03:45:22PM +0200, Antoine Tenart wrote: > > > Convert the PPv2 driver to use phylink, which models the MAC to PHY

Re: [PATCH net-next] net: mvpp2: phylink support

2017-09-25 Thread Antoine Tenart
Hi Russell, On Fri, Sep 22, 2017 at 12:07:31PM +0100, Russell King - ARM Linux wrote: > On Thu, Sep 21, 2017 at 03:45:22PM +0200, Antoine Tenart wrote: > > Convert the PPv2 driver to use phylink, which models the MAC to PHY > > link. The phylink support is made such a way the GoP link IRQ can stil

Re: [PATCH net-next] net: mvpp2: phylink support

2017-09-22 Thread Russell King - ARM Linux
On Thu, Sep 21, 2017 at 03:45:22PM +0200, Antoine Tenart wrote: > Convert the PPv2 driver to use phylink, which models the MAC to PHY > link. The phylink support is made such a way the GoP link IRQ can still > be used: the two modes are incompatible and the GoP link IRQ will be > used if no PHY is

Re: [PATCH net-next] net: mvpp2: phylink support

2017-09-22 Thread Marcin Wojtas
Hi Antoine, You can add Tested-by: Marcin Wojtas Best regards, Marcin 2017-09-21 15:45 GMT+02:00 Antoine Tenart : > Convert the PPv2 driver to use phylink, which models the MAC to PHY > link. The phylink support is made such a way the GoP link IRQ can still > be used: the two modes are incompat