Re: [PATCH net-next 1/2] socket: Allow external sockets to use socket syscalls

2014-12-26 Thread Alex Gartrell
Hello Al, On 12/26/14 2:56 PM, Al Viro wrote: On Thu, Dec 25, 2014 at 10:50:23PM -0800, Alex Gartrell wrote: Currently the "is-socket" test for a file compares the ops table pointer, which is static and local to the socket.c. Instead, this adds a flag for private_data_is_socket. This is an ex

Re: [PATCH net-next 1/2] socket: Allow external sockets to use socket syscalls

2014-12-26 Thread Al Viro
On Thu, Dec 25, 2014 at 10:50:23PM -0800, Alex Gartrell wrote: > Currently the "is-socket" test for a file compares the ops table pointer, > which is static and local to the socket.c. Instead, this adds a flag for > private_data_is_socket. This is an exceptionally long commit message for a > two-

Re: [PATCH net-next 1/2] socket: Allow external sockets to use socket syscalls

2014-12-26 Thread Alex Gartrell
Hello Jason, Thanks again for your comments. On 12/26/14 4:45 AM, Jason Wang wrote: @@ -388,6 +388,7 @@ struct file *sock_alloc_file(struct socket *sock, int flags, const char *dname) sock->file = file; file->f_flags = O_RDWR | (flags & O_NONBLOCK); file->private_data =

Re: [PATCH net-next 1/2] socket: Allow external sockets to use socket syscalls

2014-12-26 Thread Jason Wang
On 12/26/2014 02:50 PM, Alex Gartrell wrote: > Currently the "is-socket" test for a file compares the ops table pointer, > which is static and local to the socket.c. Instead, this adds a flag for > private_data_is_socket. This is an exceptionally long commit message for a > two-line patch. > > S