Re: [PATCH net-next 1/3] net: phy: broadcom: Remove unused flags

2021-02-12 Thread Florian Fainelli
On 2/12/2021 5:14 PM, Vladimir Oltean wrote: > On Fri, Feb 12, 2021 at 05:08:58PM -0800, Florian Fainelli wrote: >> That's right, tg3 drove a lot of the Broadcom PHY driver changes back >> then, I also would like to rework the way we pass flags towards PHY >> drivers because tg3 is basically the

Re: [PATCH net-next 1/3] net: phy: broadcom: Remove unused flags

2021-02-12 Thread Vladimir Oltean
On Fri, Feb 12, 2021 at 05:08:58PM -0800, Florian Fainelli wrote: > That's right, tg3 drove a lot of the Broadcom PHY driver changes back > then, I also would like to rework the way we pass flags towards PHY > drivers because tg3 is basically the only driver doing it right, where > it checks the PH

Re: [PATCH net-next 1/3] net: phy: broadcom: Remove unused flags

2021-02-12 Thread Florian Fainelli
On 2/12/2021 4:56 PM, Vladimir Oltean wrote: > On Fri, Feb 12, 2021 at 12:57:19PM -0800, Florian Fainelli wrote: >> We have a number of unused flags defined today and since we are scarce >> on space and may need to introduce new flags in the future remove and >> shift every existing flag down in

Re: [PATCH net-next 1/3] net: phy: broadcom: Remove unused flags

2021-02-12 Thread Vladimir Oltean
On Fri, Feb 12, 2021 at 12:57:19PM -0800, Florian Fainelli wrote: > We have a number of unused flags defined today and since we are scarce > on space and may need to introduce new flags in the future remove and > shift every existing flag down into a contiguous assignment. No > functional change. >