Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-11-23 Thread Sergey Ryazanov
On 21.11.2024 23:23, Antonio Quartulli wrote: On 21/11/2024 00:22, Sergey Ryazanov wrote: On 13.11.2024 12:03, Sabrina Dubroca wrote: 2024-11-13, 03:37:13 +0200, Sergey Ryazanov wrote: On 12.11.2024 19:31, Sabrina Dubroca wrote: 2024-11-10, 15:38:27 +0200, Sergey Ryazanov wrote: On 29.10.202

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-11-21 Thread Antonio Quartulli
On 20/11/2024 12:56, Sabrina Dubroca wrote: 2024-10-29, 11:47:19 +0100, Antonio Quartulli wrote: +/** + * struct ovpn_peer - the main remote peer object + * @ovpn: main openvpn instance this peer belongs to + * @id: unique identifier + * @vpn_addrs: IP addresses assigned over the tunnel + * @

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-11-21 Thread Antonio Quartulli
On 21/11/2024 00:22, Sergey Ryazanov wrote: On 13.11.2024 12:03, Sabrina Dubroca wrote: 2024-11-13, 03:37:13 +0200, Sergey Ryazanov wrote: On 12.11.2024 19:31, Sabrina Dubroca wrote: 2024-11-10, 15:38:27 +0200, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: An ovpn_peer

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-11-20 Thread Sergey Ryazanov
On 13.11.2024 12:03, Sabrina Dubroca wrote: 2024-11-13, 03:37:13 +0200, Sergey Ryazanov wrote: On 12.11.2024 19:31, Sabrina Dubroca wrote: 2024-11-10, 15:38:27 +0200, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: An ovpn_peer object holds the whole status of a remote pe

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-11-20 Thread Sabrina Dubroca
2024-10-29, 11:47:19 +0100, Antonio Quartulli wrote: > +/** > + * struct ovpn_peer - the main remote peer object > + * @ovpn: main openvpn instance this peer belongs to > + * @id: unique identifier > + * @vpn_addrs: IP addresses assigned over the tunnel > + * @vpn_addrs.ipv4: IPv4 assigned to peer

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-11-14 Thread Antonio Quartulli
On 10/11/2024 20:52, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: [...] +static void ovpn_peer_release(struct ovpn_peer *peer) +{ +    ovpn_bind_reset(peer, NULL); + nit: this empty line after ovpn_bind_reset() is removed in the 'implement basic TX path (UDP)' patch.

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-11-13 Thread Sabrina Dubroca
2024-11-13, 03:37:13 +0200, Sergey Ryazanov wrote: > On 12.11.2024 19:31, Sabrina Dubroca wrote: > > 2024-11-10, 15:38:27 +0200, Sergey Ryazanov wrote: > > > On 29.10.2024 12:47, Antonio Quartulli wrote: > > > > An ovpn_peer object holds the whole status of a remote peer > > > > (regardless whether

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-11-12 Thread Sergey Ryazanov
On 12.11.2024 19:31, Sabrina Dubroca wrote: 2024-11-10, 15:38:27 +0200, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: An ovpn_peer object holds the whole status of a remote peer (regardless whether it is a server or a client). This includes status for crypto, tx/rx buffe

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-11-12 Thread Sabrina Dubroca
2024-11-10, 15:38:27 +0200, Sergey Ryazanov wrote: > On 29.10.2024 12:47, Antonio Quartulli wrote: > > An ovpn_peer object holds the whole status of a remote peer > > (regardless whether it is a server or a client). > > > > This includes status for crypto, tx/rx buffers, napi, etc. > > > > Only s

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-11-12 Thread Antonio Quartulli
On 05/11/2024 14:12, Sabrina Dubroca wrote: 2024-10-30, 21:47:58 +0100, Antonio Quartulli wrote: On 30/10/2024 17:37, Sabrina Dubroca wrote: 2024-10-29, 11:47:19 +0100, Antonio Quartulli wrote: +static void ovpn_peer_release(struct ovpn_peer *peer) +{ + ovpn_bind_reset(peer, NULL); + +

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-11-10 Thread Sergey Ryazanov
On 29.10.2024 12:47, Antonio Quartulli wrote: [...] +static void ovpn_peer_release(struct ovpn_peer *peer) +{ + ovpn_bind_reset(peer, NULL); + nit: this empty line after ovpn_bind_reset() is removed in the 'implement basic TX path (UDP)' patch. What tricks git and it produces a sensle

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-11-10 Thread Sergey Ryazanov
On 29.10.2024 12:47, Antonio Quartulli wrote: An ovpn_peer object holds the whole status of a remote peer (regardless whether it is a server or a client). This includes status for crypto, tx/rx buffers, napi, etc. Only support for one peer is introduced (P2P mode). Multi peer support is introdu

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-11-05 Thread Sabrina Dubroca
2024-10-30, 21:47:58 +0100, Antonio Quartulli wrote: > On 30/10/2024 17:37, Sabrina Dubroca wrote: > > 2024-10-29, 11:47:19 +0100, Antonio Quartulli wrote: > > > +static void ovpn_peer_release(struct ovpn_peer *peer) > > > +{ > > > + ovpn_bind_reset(peer, NULL); > > > + > > > + dst_cache_destroy(&p

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-10-30 Thread Antonio Quartulli
On 30/10/2024 17:37, Sabrina Dubroca wrote: 2024-10-29, 11:47:19 +0100, Antonio Quartulli wrote: +static void ovpn_peer_release(struct ovpn_peer *peer) +{ + ovpn_bind_reset(peer, NULL); + + dst_cache_destroy(&peer->dst_cache); Is it safe to destroy the cache at this time? In the sa

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-10-30 Thread Sabrina Dubroca
2024-10-29, 11:47:19 +0100, Antonio Quartulli wrote: > +static void ovpn_peer_release(struct ovpn_peer *peer) > +{ > + ovpn_bind_reset(peer, NULL); > + > + dst_cache_destroy(&peer->dst_cache); Is it safe to destroy the cache at this time? In the same function, we use rcu to free the peer,