Re: [PATCH net-next v11 12/23] ovpn: implement TCP transport

2024-11-26 Thread Antonio Quartulli
On 26/11/2024 02:05, Sergey Ryazanov wrote: Hi Antonio, the question was addressed to Sabrina, but since I've already touched this topic in the another patch, let me put my 2c here. On 16.11.2024 02:33, Antonio Quartulli wrote: On 31/10/2024 16:25, Sabrina Dubroca wrote: 2024-10-29, 11:47:2

Re: [PATCH net-next v11 12/23] ovpn: implement TCP transport

2024-11-25 Thread Sergey Ryazanov
Hi Antonio, the question was addressed to Sabrina, but since I've already touched this topic in the another patch, let me put my 2c here. On 16.11.2024 02:33, Antonio Quartulli wrote: On 31/10/2024 16:25, Sabrina Dubroca wrote: 2024-10-29, 11:47:25 +0100, Antonio Quartulli wrote: +static vo

Re: [PATCH net-next v11 12/23] ovpn: implement TCP transport

2024-11-15 Thread Antonio Quartulli
On 31/10/2024 16:25, Sabrina Dubroca wrote: 2024-10-29, 11:47:25 +0100, Antonio Quartulli wrote: +static void ovpn_socket_release_work(struct work_struct *work) +{ + struct ovpn_socket *sock = container_of(work, struct ovpn_socket, work); + + ovpn_socket_detach(sock->sock); + k

Re: [PATCH net-next v11 12/23] ovpn: implement TCP transport

2024-10-31 Thread Sabrina Dubroca
2024-10-29, 11:47:25 +0100, Antonio Quartulli wrote: > +static void ovpn_socket_release_work(struct work_struct *work) > +{ > + struct ovpn_socket *sock = container_of(work, struct ovpn_socket, work); > + > + ovpn_socket_detach(sock->sock); > + kfree_rcu(sock, rcu); > +} > + > +static v

Re: [PATCH net-next v11 12/23] ovpn: implement TCP transport

2024-10-31 Thread Antonio Quartulli
On 29/10/2024 11:47, Antonio Quartulli wrote: [...] + + /* DATA_V2 packets are handled in kernel, the rest goes to user space */ + if (likely(ovpn_opcode_from_skb(skb, 0) == OVPN_DATA_V2)) { + /* hold reference to peer as required by ovpn_recv(). +* +