Re: [PATCH net-next v2] net-sysfs: expose number of carrier on/off changes

2014-03-31 Thread David Miller
From: David Decotigny Date: Sat, 29 Mar 2014 09:48:35 -0700 > This allows to monitor carrier on/off transitions and detect link > flapping issues: > - new /sys/class/net/X/carrier_changes > - new rtnetlink IFLA_CARRIER_CHANGES (getlink) > > Tested: > - grep . /sys/class/net/*/carrier_changes

Re: [PATCH net-next v2] net-sysfs: expose number of carrier on/off changes

2014-03-31 Thread Florian Fainelli
Hi David, 2014-03-30 8:18 GMT-07:00 David Decotigny : > Hi all, > > As Eric mentioned, this is a per-link counter. I am not sure an > aggregate stat would be as useful. > > As suggested by Florian, I'm planning to add a doc. As far as I can > tell, I think it goes beyond just documenting this new

Re: [PATCH net-next v2] net-sysfs: expose number of carrier on/off changes

2014-03-30 Thread David Decotigny
Hi all, As Eric mentioned, this is a per-link counter. I am not sure an aggregate stat would be as useful. As suggested by Florian, I'm planning to add a doc. As far as I can tell, I think it goes beyond just documenting this new counter: I believe sysfs-class-net needs to be added as a whole. S

Re: [PATCH net-next v2] net-sysfs: expose number of carrier on/off changes

2014-03-29 Thread Eric Dumazet
On Sat, 2014-03-29 at 18:36 -0700, Stephen Hemminger wrote: > On Sat, 29 Mar 2014 09:48:35 -0700 > David Decotigny wrote: > > > This allows to monitor carrier on/off transitions and detect link > > flapping issues: > > - new /sys/class/net/X/carrier_changes > > - new rtnetlink IFLA_CARRIER_CHAN

Re: [PATCH net-next v2] net-sysfs: expose number of carrier on/off changes

2014-03-29 Thread Stephen Hemminger
On Sat, 29 Mar 2014 09:48:35 -0700 David Decotigny wrote: > This allows to monitor carrier on/off transitions and detect link > flapping issues: > - new /sys/class/net/X/carrier_changes > - new rtnetlink IFLA_CARRIER_CHANGES (getlink) > > Tested: > - grep . /sys/class/net/*/carrier_changes >