Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

On 15. sep. 2017 07:51, Jiri Pirko wrote: > Thu, Sep 14, 2017 at 11:01:32PM CEST, and...@lunn.ch wrote: >>> Can you clarify what type of registers it is you are wanting to read? >>> We already have ethtool which is meant to allow reading the device >>> registers for a given netdev. As long as the

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

On 15. sep. 2017 07:51, Jiri Pirko wrote: > Thu, Sep 14, 2017 at 11:01:32PM CEST, and...@lunn.ch wrote: >>> Can you clarify what type of registers it is you are wanting to read? >>> We already have ethtool which is meant to allow reading the device >>> registers for a given netdev. As long as the

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

Thu, Sep 14, 2017 at 11:01:32PM CEST, and...@lunn.ch wrote: >> Can you clarify what type of registers it is you are wanting to read? >> We already have ethtool which is meant to allow reading the device >> registers for a given netdev. As long as the port has a netdev >> associated it then there

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

Thu, Sep 14, 2017 at 11:01:32PM CEST, and...@lunn.ch wrote: >> Can you clarify what type of registers it is you are wanting to read? >> We already have ethtool which is meant to allow reading the device >> registers for a given netdev. As long as the port has a netdev >> associated it then there

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

> Can you clarify what type of registers it is you are wanting to read? > We already have ethtool which is meant to allow reading the device > registers for a given netdev. As long as the port has a netdev > associated it then there is no need to be getting into debugfs since > we should probably

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

> Can you clarify what type of registers it is you are wanting to read? > We already have ethtool which is meant to allow reading the device > registers for a given netdev. As long as the port has a netdev > associated it then there is no need to be getting into debugfs since > we should probably

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

On Thu, Sep 14, 2017 at 12:59 PM, Maxim Uvarov wrote: > debugfs here is very very useful to read registers directly and > compare what use space tools see. Cool feature to get regs by port and > use standard tools to diff and print them. Even might be better to > allow drivers

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

On Thu, Sep 14, 2017 at 12:59 PM, Maxim Uvarov wrote: > debugfs here is very very useful to read registers directly and > compare what use space tools see. Cool feature to get regs by port and > use standard tools to diff and print them. Even might be better to > allow drivers to decode register

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

debugfs here is very very useful to read registers directly and compare what use space tools see. Cool feature to get regs by port and use standard tools to diff and print them. Even might be better to allow drivers to decode register names and bits values. Once that is done driver mainaince will

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

debugfs here is very very useful to read registers directly and compare what use space tools see. Cool feature to get regs by port and use standard tools to diff and print them. Even might be better to allow drivers to decode register names and bits values. Once that is done driver mainaince will

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

Hi Greg, Greg KH writes: > I agree you shouldn't be using debugfs for this, but in the future, if > you do write debugfs code, please take the following review into > account: Humm sorry I may not have given enough details. This was really meant for debug and dev

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

Hi Greg, Greg KH writes: > I agree you shouldn't be using debugfs for this, but in the future, if > you do write debugfs code, please take the following review into > account: Humm sorry I may not have given enough details. This was really meant for debug and dev only, because DSA makes it

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

I agree you shouldn't be using debugfs for this, but in the future, if you do write debugfs code, please take the following review into account: On Mon, Aug 28, 2017 at 03:17:39PM -0400, Vivien Didelot wrote: > +static int dsa_debugfs_create_port(struct dsa_switch *ds, int port) > +{ > +

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

I agree you shouldn't be using debugfs for this, but in the future, if you do write debugfs code, please take the following review into account: On Mon, Aug 28, 2017 at 03:17:39PM -0400, Vivien Didelot wrote: > +static int dsa_debugfs_create_port(struct dsa_switch *ds, int port) > +{ > +

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

On Mon, Aug 28, 2017 at 03:17:39PM -0400, Vivien Didelot wrote: > This commit adds a DEBUG_FS dependent DSA core file creating a generic > debug filesystem interface for the DSA switch devices. > > The interface can be mounted with: > > # mount -t debugfs none /sys/kernel/debug > > The dsa

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

On Mon, Aug 28, 2017 at 03:17:39PM -0400, Vivien Didelot wrote: > This commit adds a DEBUG_FS dependent DSA core file creating a generic > debug filesystem interface for the DSA switch devices. > > The interface can be mounted with: > > # mount -t debugfs none /sys/kernel/debug > > The dsa

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

Mon, Aug 28, 2017 at 09:58:12PM CEST, f.faine...@gmail.com wrote: >On 08/28/2017 12:50 PM, Jiri Pirko wrote: >> Mon, Aug 28, 2017 at 09:17:39PM CEST, vivien.dide...@savoirfairelinux.com >> wrote: >>> This commit adds a DEBUG_FS dependent DSA core file creating a generic >>> debug filesystem

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

Mon, Aug 28, 2017 at 09:58:12PM CEST, f.faine...@gmail.com wrote: >On 08/28/2017 12:50 PM, Jiri Pirko wrote: >> Mon, Aug 28, 2017 at 09:17:39PM CEST, vivien.dide...@savoirfairelinux.com >> wrote: >>> This commit adds a DEBUG_FS dependent DSA core file creating a generic >>> debug filesystem

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

On 08/28/2017 12:50 PM, Jiri Pirko wrote: > Mon, Aug 28, 2017 at 09:17:39PM CEST, vivien.dide...@savoirfairelinux.com > wrote: >> This commit adds a DEBUG_FS dependent DSA core file creating a generic >> debug filesystem interface for the DSA switch devices. >> >> The interface can be mounted

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

On 08/28/2017 12:50 PM, Jiri Pirko wrote: > Mon, Aug 28, 2017 at 09:17:39PM CEST, vivien.dide...@savoirfairelinux.com > wrote: >> This commit adds a DEBUG_FS dependent DSA core file creating a generic >> debug filesystem interface for the DSA switch devices. >> >> The interface can be mounted

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

Mon, Aug 28, 2017 at 09:17:39PM CEST, vivien.dide...@savoirfairelinux.com wrote: >This commit adds a DEBUG_FS dependent DSA core file creating a generic >debug filesystem interface for the DSA switch devices. > >The interface can be mounted with: > ># mount -t debugfs none /sys/kernel/debug >

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

Mon, Aug 28, 2017 at 09:17:39PM CEST, vivien.dide...@savoirfairelinux.com wrote: >This commit adds a DEBUG_FS dependent DSA core file creating a generic >debug filesystem interface for the DSA switch devices. > >The interface can be mounted with: > ># mount -t debugfs none /sys/kernel/debug >