Re: [PATCH net-next v5 1/2] net: add support for Cavium PTP coprocessor

2017-12-12 Thread Richard Cochran
On Tue, Dec 12, 2017 at 12:41:35PM +0300, Aleksey Makarov wrote: > If ptp_clock_register() returns NULL, the device is still paired with the > driver, > but the driver is not registered in the PTP core. When ethernet driver needs > the reference to this cavium PTP driver, it calls cavium_ptp_get(

Re: [PATCH net-next v5 1/2] net: add support for Cavium PTP coprocessor

2017-12-12 Thread Aleksey Makarov
Hi Richard, On 12/12/2017 01:59 AM, Richard Cochran wrote: Sorry I didn't finish reviewing before... On Mon, Dec 11, 2017 at 05:14:30PM +0300, Aleksey Makarov wrote: [ ... ] +static int cavium_ptp_probe(struct pci_dev *pdev, + const struct pci_device_id *ent) +{ +

Re: [PATCH net-next v5 1/2] net: add support for Cavium PTP coprocessor

2017-12-11 Thread Richard Cochran
Sorry I didn't finish reviewing before... On Mon, Dec 11, 2017 at 05:14:30PM +0300, Aleksey Makarov wrote: > +/** > + * cavium_ptp_adjfreq() - Adjust ptp frequency > + * @ptp: PTP clock info > + * @ppb: how much to adjust by, in parts-per-billion > + */ > +static int cavium_ptp_adjfreq(struct ptp