RE: [PATCH net 1/2] r8169: fix the default setting of rx vlan

2014-09-15 Thread Hayes Wang
From: Francois Romieu [mailto:rom...@fr.zoreil.com] > Sent: Tuesday, September 16, 2014 8:03 AM [...] > However it's getting messy and the code stomps CPlusCmd in > rtl_open right > before it's given a chance to be read in hw_start. Something like the > untested patch below should avoid it and k

Re: [PATCH net 1/2] r8169: fix the default setting of rx vlan

2014-09-15 Thread Francois Romieu
Hayes Wang : > Francois Romieu [mailto:rom...@fr.zoreil.com] > > Sent: Saturday, September 13, 2014 3:40 AM > [...] > > The same fix should be relevant for NETIF_F_RXCSUM. You may thus as > > well remove the "changed" test in __rtl8169_set_features and keep > > everything there. > > In the prob

RE: [PATCH net 1/2] r8169: fix the default setting of rx vlan

2014-09-14 Thread Hayes Wang
Francois Romieu [mailto:rom...@fr.zoreil.com] > Sent: Saturday, September 13, 2014 3:40 AM [...] > The same fix should be relevant for NETIF_F_RXCSUM. You may thus as > well remove the "changed" test in __rtl8169_set_features and keep > everything there. In the probe function (rtl_init_one), RxC

Re: [PATCH net 1/2] r8169: fix the default setting of rx vlan

2014-09-12 Thread Francois Romieu
Hayes Wang : > If the parameter "features" of __rtl8169_set_features() is equal to > dev->features, the variable "changed" is alwayes 0, and nothing would > be changed. [...] > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 91652e7..f3ce284 1006