Ok I applied this series, thanks!
From: Finn Thain
Date: Tue, 20 Feb 2018 11:42:26 +1100 (AEDT)
> If there was an unused variables I would happily remove that too but the
> 'version' string is not unused. The etherh.c and mac8390.c files both
> include "lib8390.c" and in there you'll find the 'version' string used in
> ethdev_
On Mon, 19 Feb 2018, David Miller wrote:
> > On Mon, 19 Feb 2018, David Miller wrote:
> >
> >> > The lib8390 module parameter 'msg_enable' doesn't do anything
> >> > useful: it causes an ancient version string to be logged.
> >>
> >> Since you are removing the last reference to this 'version' s
From: Finn Thain
Date: Tue, 20 Feb 2018 09:01:11 +1100 (AEDT)
> On Mon, 19 Feb 2018, David Miller wrote:
>
>> From: Finn Thain
>> Date: Sun, 18 Feb 2018 21:39:17 -0500 (EST)
>>
>> > The lib8390 module parameter 'msg_enable' doesn't do anything useful:
>> > it causes an ancient version string t
On Mon, 19 Feb 2018, David Miller wrote:
> From: Finn Thain
> Date: Sun, 18 Feb 2018 21:39:17 -0500 (EST)
>
> > The lib8390 module parameter 'msg_enable' doesn't do anything useful:
> > it causes an ancient version string to be logged.
>
> Since you are removing the last reference to this 'vers
From: Finn Thain
Date: Sun, 18 Feb 2018 21:39:17 -0500 (EST)
> The lib8390 module parameter 'msg_enable' doesn't do anything useful:
> it causes an ancient version string to be logged.
Since you are removing the last reference to this 'version' string
you should remove it as well.
I'm surprised
6 matches
Mail list logo
