Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-28 Thread Paul E. McKenney
On Tue, May 28, 2013 at 12:07:42PM +0200, Ingo Molnar wrote: > > * Paul E. McKenney wrote: > > > On Wed, May 15, 2013 at 11:20:55AM +0200, Ingo Molnar wrote: > > > > > > * Paul E. McKenney wrote: > > > > > > > rcu: Fix comparison sense in rcu_needs_cpu() > > > > > > > > Commit c0f4dfd4f (rcu

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-28 Thread Ingo Molnar
* Paul E. McKenney wrote: > On Wed, May 15, 2013 at 11:20:55AM +0200, Ingo Molnar wrote: > > > > * Paul E. McKenney wrote: > > > > > rcu: Fix comparison sense in rcu_needs_cpu() > > > > > > Commit c0f4dfd4f (rcu: Make RCU_FAST_NO_HZ take advantage of numbered > > > callbacks) introduced a bu

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-21 Thread Paul E. McKenney
On Tue, May 21, 2013 at 11:45:31AM +0200, Peter Zijlstra wrote: > On Thu, May 16, 2013 at 06:22:10AM -0700, Paul E. McKenney wrote: > > > But somehow I imagined making a CPU part of the GP would be easier than > > > taking > > > it out. After all, taking it out is dangerous and careful work, one i

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-21 Thread Peter Zijlstra
On Thu, May 16, 2013 at 06:22:10AM -0700, Paul E. McKenney wrote: > > But somehow I imagined making a CPU part of the GP would be easier than > > taking > > it out. After all, taking it out is dangerous and careful work, one is not > > to > > accidentally execute a callback or otherwise end a GP

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-16 Thread Paul E. McKenney
On Thu, May 16, 2013 at 11:45:19AM +0200, Peter Zijlstra wrote: > On Wed, May 15, 2013 at 10:31:42AM -0700, Paul E. McKenney wrote: > > On Wed, May 15, 2013 at 11:02:34AM +0200, Peter Zijlstra wrote: > > > > Earlier you said that improving EQS behaviour was expensive in that it > > > would require

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-16 Thread Paul E. McKenney
On Thu, May 16, 2013 at 11:37:40AM +0200, Peter Zijlstra wrote: > On Wed, May 15, 2013 at 09:37:00AM -0700, Paul E. McKenney wrote: > > The need is to detect that an idle CPU is idle without making it do > > anything. To do otherwise would kill battery lifetime and introduce > > OS jitter. > > No

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-16 Thread Peter Zijlstra
On Wed, May 15, 2013 at 10:31:42AM -0700, Paul E. McKenney wrote: > On Wed, May 15, 2013 at 11:02:34AM +0200, Peter Zijlstra wrote: > > Earlier you said that improving EQS behaviour was expensive in that it > > would require taking (global) locks or somesuch. > > > > Would it not be possible to h

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-16 Thread Peter Zijlstra
On Wed, May 15, 2013 at 09:37:00AM -0700, Paul E. McKenney wrote: > The need is to detect that an idle CPU is idle without making it do > anything. To do otherwise would kill battery lifetime and introduce > OS jitter. Not anything isn't leaving us much room to wriggle, we could maybe try and do

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-15 Thread Paul E. McKenney
On Wed, May 15, 2013 at 11:02:34AM +0200, Peter Zijlstra wrote: > On Wed, May 15, 2013 at 10:56:39AM +0200, Peter Zijlstra wrote: > > On Tue, May 14, 2013 at 08:47:28AM -0700, Paul E. McKenney wrote: > > > On Tue, May 14, 2013 at 04:51:20PM +0200, Peter Zijlstra wrote: > > > > > In theory, yes. In

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-15 Thread Paul E. McKenney
On Wed, May 15, 2013 at 10:56:39AM +0200, Peter Zijlstra wrote: > On Tue, May 14, 2013 at 08:47:28AM -0700, Paul E. McKenney wrote: > > On Tue, May 14, 2013 at 04:51:20PM +0200, Peter Zijlstra wrote: > > > > In theory, yes. In practice, this requires lots of lock acquisitions > > > > and releases

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-15 Thread Paul E. McKenney
On Wed, May 15, 2013 at 11:20:55AM +0200, Ingo Molnar wrote: > > * Paul E. McKenney wrote: > > > rcu: Fix comparison sense in rcu_needs_cpu() > > > > Commit c0f4dfd4f (rcu: Make RCU_FAST_NO_HZ take advantage of numbered > > callbacks) introduced a bug that can result in excessively long grace >

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-15 Thread Ingo Molnar
* Paul E. McKenney wrote: > rcu: Fix comparison sense in rcu_needs_cpu() > > Commit c0f4dfd4f (rcu: Make RCU_FAST_NO_HZ take advantage of numbered > callbacks) introduced a bug that can result in excessively long grace > periods. This bug reverse the senes of the "if" statement checking > for

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-15 Thread Peter Zijlstra
On Wed, May 15, 2013 at 10:56:39AM +0200, Peter Zijlstra wrote: > On Tue, May 14, 2013 at 08:47:28AM -0700, Paul E. McKenney wrote: > > On Tue, May 14, 2013 at 04:51:20PM +0200, Peter Zijlstra wrote: > > > > In theory, yes. In practice, this requires lots of lock acquisitions > > > > and releases

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-15 Thread Peter Zijlstra
On Tue, May 14, 2013 at 08:47:28AM -0700, Paul E. McKenney wrote: > On Tue, May 14, 2013 at 04:51:20PM +0200, Peter Zijlstra wrote: > > > In theory, yes. In practice, this requires lots of lock acquisitions > > > and releases on large systems, including some global locks. The weight > > > could b

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-14 Thread Paul E. McKenney
On Tue, May 14, 2013 at 04:51:20PM +0200, Peter Zijlstra wrote: > > In theory, yes. In practice, this requires lots of lock acquisitions > > and releases on large systems, including some global locks. The weight > > could be reduced, but... > > > > What I would like to do instead would be to spe

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-14 Thread Peter Zijlstra
> In theory, yes. In practice, this requires lots of lock acquisitions > and releases on large systems, including some global locks. The weight > could be reduced, but... > > What I would like to do instead would be to specify expedited grace > periods during boot. But why, surely going idle wi

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-14 Thread Paul E. McKenney
On Tue, May 14, 2013 at 02:20:49PM +0200, Peter Zijlstra wrote: > On Sat, Apr 13, 2013 at 03:09:43PM -0700, Paul E. McKenney wrote: > > > How are those CPUs going idle without first telling RCU that they're > > > quiesced? Seems like, during boot at least, you want RCU to use its > > > idle==quies

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-05-14 Thread Peter Zijlstra
On Sat, Apr 13, 2013 at 03:09:43PM -0700, Paul E. McKenney wrote: > > How are those CPUs going idle without first telling RCU that they're > > quiesced? Seems like, during boot at least, you want RCU to use its > > idle==quiesced logic to proactively note continuously-quiescent states. > > Ideally

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-04-15 Thread Paul E. McKenney
On Mon, Apr 15, 2013 at 12:03:54PM +1000, Paul Mackerras wrote: > On Fri, Apr 12, 2013 at 11:38:04PM -0700, Paul E. McKenney wrote: > > On Fri, Apr 12, 2013 at 04:54:02PM -0700, Josh Triplett wrote: > > > On Fri, Apr 12, 2013 at 04:19:13PM -0700, Paul E. McKenney wrote: > > > > From: "Paul E. McKen

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-04-14 Thread Paul Mackerras
On Fri, Apr 12, 2013 at 11:38:04PM -0700, Paul E. McKenney wrote: > On Fri, Apr 12, 2013 at 04:54:02PM -0700, Josh Triplett wrote: > > On Fri, Apr 12, 2013 at 04:19:13PM -0700, Paul E. McKenney wrote: > > > From: "Paul E. McKenney" > > > > > > Systems with HZ=100 can have slow bootup times due to

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-04-13 Thread Paul E. McKenney
On Sat, Apr 13, 2013 at 03:09:43PM -0700, Paul E. McKenney wrote: > On Sat, Apr 13, 2013 at 12:53:36PM -0700, Josh Triplett wrote: > > On Sat, Apr 13, 2013 at 12:34:25PM -0700, Paul E. McKenney wrote: > > > On Sat, Apr 13, 2013 at 11:18:00AM -0700, Josh Triplett wrote: > > > > On Fri, Apr 12, 2013

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-04-13 Thread Paul E. McKenney
On Sat, Apr 13, 2013 at 12:53:36PM -0700, Josh Triplett wrote: > On Sat, Apr 13, 2013 at 12:34:25PM -0700, Paul E. McKenney wrote: > > On Sat, Apr 13, 2013 at 11:18:00AM -0700, Josh Triplett wrote: > > > On Fri, Apr 12, 2013 at 11:38:04PM -0700, Paul E. McKenney wrote: > > > > On Fri, Apr 12, 2013

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-04-13 Thread Josh Triplett
On Sat, Apr 13, 2013 at 12:34:25PM -0700, Paul E. McKenney wrote: > On Sat, Apr 13, 2013 at 11:18:00AM -0700, Josh Triplett wrote: > > On Fri, Apr 12, 2013 at 11:38:04PM -0700, Paul E. McKenney wrote: > > > On Fri, Apr 12, 2013 at 04:54:02PM -0700, Josh Triplett wrote: > > > > On Fri, Apr 12, 2013

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-04-13 Thread Paul E. McKenney
On Sat, Apr 13, 2013 at 11:18:00AM -0700, Josh Triplett wrote: > On Fri, Apr 12, 2013 at 11:38:04PM -0700, Paul E. McKenney wrote: > > On Fri, Apr 12, 2013 at 04:54:02PM -0700, Josh Triplett wrote: > > > On Fri, Apr 12, 2013 at 04:19:13PM -0700, Paul E. McKenney wrote: > > > > From: "Paul E. McKenn

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-04-13 Thread Josh Triplett
On Fri, Apr 12, 2013 at 11:38:04PM -0700, Paul E. McKenney wrote: > On Fri, Apr 12, 2013 at 04:54:02PM -0700, Josh Triplett wrote: > > On Fri, Apr 12, 2013 at 04:19:13PM -0700, Paul E. McKenney wrote: > > > From: "Paul E. McKenney" > > > > > > Systems with HZ=100 can have slow bootup times due to

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-04-12 Thread Paul E. McKenney
On Fri, Apr 12, 2013 at 04:54:02PM -0700, Josh Triplett wrote: > On Fri, Apr 12, 2013 at 04:19:13PM -0700, Paul E. McKenney wrote: > > From: "Paul E. McKenney" > > > > Systems with HZ=100 can have slow bootup times due to the default > > three-jiffy delays between quiescent-state forcing attempts

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-04-12 Thread Josh Triplett
On Fri, Apr 12, 2013 at 04:19:13PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > Systems with HZ=100 can have slow bootup times due to the default > three-jiffy delays between quiescent-state forcing attempts. This > commit therefore auto-tunes the RCU_JIFFIES_TILL_FORCE_QS value