Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-16 Thread Dmitry Torokhov
On 10/16/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > On 10/16/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > On 10/15/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > > > On 10/15/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > > > > > > > Completion is just not a good abstraction here... Please use

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-16 Thread Ahmed S. Darwish
On Tue, Oct 16, 2007 at 02:08:04PM +0800, Bryan Wu wrote: > On 10/16/07, Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > > On Mon, Oct 15, 2007 at 11:48:17AM -0400, Dmitry Torokhov wrote: > > > Hi Bryan, > > > > > > On 10/15/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > > > > + > > > > +static int ad7142

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-15 Thread Bryan Wu
On 10/16/07, Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > On Mon, Oct 15, 2007 at 11:48:17AM -0400, Dmitry Torokhov wrote: > > Hi Bryan, > > > > On 10/15/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > > > + > > > +static int ad7142_thread(void *nothing) > > > +{ > > > + do { > > > +

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-15 Thread Bryan Wu
On 10/16/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > On 10/15/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > > On 10/15/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > > > > > Completion is just not a good abstraction here... Please use work > > > abstraction and possibly a separate workqueue. >

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-15 Thread Jean Delvare
On Mon, 15 Oct 2007 11:48:17 -0400, Dmitry Torokhov wrote: > On 10/15/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > > +static int __init ad7142_init(void) > > +{ > > + return i2c_add_driver(&ad7142_driver); > > +} > > + > > +static void __exit ad7142_exit(void) > > +{ > > + i2c_del_driver(&

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-15 Thread Ahmed S. Darwish
On Mon, Oct 15, 2007 at 11:48:17AM -0400, Dmitry Torokhov wrote: > Hi Bryan, > > On 10/15/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > > + > > +static int ad7142_thread(void *nothing) > > +{ > > + do { > > + wait_for_completion(&ad7142_completion); > > + ad7142_decod

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-15 Thread Dmitry Torokhov
On 10/15/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > On 10/15/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > > > Completion is just not a good abstraction here... Please use work > > abstraction and possibly a separate workqueue. > > Yes, I agree with you now, although I have a little concern abo

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-15 Thread Bryan Wu
On 10/15/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > Hi Bryan, > > On 10/15/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > > + > > +static int ad7142_thread(void *nothing) > > +{ > > + do { > > + wait_for_completion(&ad7142_completion); > > + ad7142_decode(); > > +

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-15 Thread Dmitry Torokhov
Hi Bryan, On 10/15/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > + > +static int ad7142_thread(void *nothing) > +{ > + do { > + wait_for_completion(&ad7142_completion); > + ad7142_decode(); > + enable_irq(CONFIG_BFIN_JOYSTICK_IRQ_PFX); > + } while