Re: [PATCH update] ieee1394: cycle timer read extension for raw1394/libraw1394

2007-02-04 Thread Pieter Palmers
Stefan Richter wrote: Pieter Palmers wrote: Stefan Richter wrote: ... - Fix integer overflow. I had to use 100ULL instead of USEC_PER_SEC to avoid weird behavior. OK, I'll change that and will wait for... I can't test it right now, but I'll report later. ...your and Dan's ACK befo

Re: [PATCH update] ieee1394: cycle timer read extension for raw1394/libraw1394

2007-02-03 Thread Pieter Palmers
Stefan Richter wrote: I wrote: +++ linux/drivers/ieee1394/raw1394.h2007-02-03 13:47:34.0 +0100 @@ -178,4 +178,14 @@ struct raw1394_iso_status { __s16 xmit_cycle; }; +/* argument to RAW1394_IOC_GET_CYCLE_TIMER ioctl */ +struct raw1394_cycle_timer { + /* contents of I

Re: [PATCH update] ieee1394: cycle timer read extension for raw1394/libraw1394

2007-02-03 Thread Stefan Richter
I wrote: > +++ linux/drivers/ieee1394/raw1394.h 2007-02-03 13:47:34.0 +0100 > @@ -178,4 +178,14 @@ struct raw1394_iso_status { > __s16 xmit_cycle; > }; > > +/* argument to RAW1394_IOC_GET_CYCLE_TIMER ioctl */ > +struct raw1394_cycle_timer { > + /* contents of Isochronous Cycle

Re: [PATCH update] ieee1394: cycle timer read extension for raw1394/libraw1394

2007-02-03 Thread Stefan Richter
I wrote: > - Rename userspace-exported struct _raw1394_cycle_timer to > raw1394_cycle_timer. Argh. This makes maintenance of libraw1394's header files more difficult. I will revert this to _raw1394_cycle_timer, unless somebody has a better idea how to deal with this issue. -- Stefan Richter

Re: [PATCH update] ieee1394: cycle timer read extension for raw1394/libraw1394

2007-02-03 Thread Stefan Richter
Pieter Palmers wrote: > Stefan Richter wrote: ... >> - Fix integer overflow. > I had to use 100ULL instead of USEC_PER_SEC to avoid weird behavior. OK, I'll change that and will wait for... > I can't test it right now, but I'll report later. ...your and Dan's ACK before I commit the patch.

Re: [PATCH update] ieee1394: cycle timer read extension for raw1394/libraw1394

2007-02-03 Thread Pieter Palmers
Stefan Richter wrote: From: Pieter Palmers <[EMAIL PROTECTED]> This implements the simultaneous read of the isochronous cycle timer and the system clock (in usecs). This allows to express the exact receive time of an ISO packet as a system time with microsecond accuracy. http://bugzilla.kernel.

which header for local_irq_save? (was Re: [PATCH update] ieee1394: cycle timer read extension for raw1394/libraw1394)

2007-02-03 Thread Stefan Richter
I wrote: > --- linux.orig/drivers/ieee1394/ieee1394_core.c 2007-01-27 > 14:07:00.0 +0100 > +++ linux/drivers/ieee1394/ieee1394_core.c2007-02-03 13:47:33.0 > +0100 > @@ -33,6 +33,9 @@ > #include > #include > #include > +#include > +#include > +#include > > #in