Re: [PATCH v1, 4/5] soc: mediatek: cmdq: add address shift in jump

2020-12-22 Thread Yongqiang Niu
On Wed, 2020-12-09 at 23:16 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Nicolas Boichat 於 2020年12月5日 週六 下午3:30寫道： > > > > On Sat, Dec 5, 2020 at 12:16 PM Yongqiang Niu > > wrote: > > > > > > Add address shift when compose jump instruction > > > to compatible with 35bit format. > > > > This

Re: [PATCH v1, 4/5] soc: mediatek: cmdq: add address shift in jump

2020-12-09 Thread Chun-Kuang Hu
Hi, Yongqiang: Nicolas Boichat 於 2020年12月5日 週六 下午3:30寫道： > > On Sat, Dec 5, 2020 at 12:16 PM Yongqiang Niu > wrote: > > > > Add address shift when compose jump instruction > > to compatible with 35bit format. > > This looks reasonable, but task->cmdq->shift_pa is not new and was > introduced as

Re: [PATCH v1, 4/5] soc: mediatek: cmdq: add address shift in jump

2020-12-04 Thread Nicolas Boichat
On Sat, Dec 5, 2020 at 12:16 PM Yongqiang Niu wrote: > > Add address shift when compose jump instruction > to compatible with 35bit format. This looks reasonable, but task->cmdq->shift_pa is not new and was introduced as part of mt6779 GCE support. Do you want to add a Fixes tag? Fixes: 0858fde4