Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-26 Thread David Hildenbrand
On 26.07.19 12:31, Michal Hocko wrote: > On Fri 26-07-19 10:57:52, David Hildenbrand wrote: >> On 26.07.19 10:44, Michal Hocko wrote: >>> On Fri 26-07-19 10:36:42, David Hildenbrand wrote: On 26.07.19 10:31, Michal Hocko wrote: >>> [...] > Anyway, my dislike of the device_hotplug_lock pers

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-26 Thread Michal Hocko
On Fri 26-07-19 10:57:52, David Hildenbrand wrote: > On 26.07.19 10:44, Michal Hocko wrote: > > On Fri 26-07-19 10:36:42, David Hildenbrand wrote: > >> On 26.07.19 10:31, Michal Hocko wrote: > > [...] > >>> Anyway, my dislike of the device_hotplug_lock persists. I would really > >>> love to see it

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-26 Thread David Hildenbrand
On 26.07.19 10:44, Michal Hocko wrote: > On Fri 26-07-19 10:36:42, David Hildenbrand wrote: >> On 26.07.19 10:31, Michal Hocko wrote: > [...] >>> Anyway, my dislike of the device_hotplug_lock persists. I would really >>> love to see it go rather than grow even more to the hotplug code. We >>> shoul

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-26 Thread Michal Hocko
On Fri 26-07-19 10:36:42, David Hildenbrand wrote: > On 26.07.19 10:31, Michal Hocko wrote: [...] > > Anyway, my dislike of the device_hotplug_lock persists. I would really > > love to see it go rather than grow even more to the hotplug code. We > > should be really striving for mem hotplug interna

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-26 Thread David Hildenbrand
On 26.07.19 10:31, Michal Hocko wrote: > On Fri 26-07-19 10:05:58, David Hildenbrand wrote: >> On 26.07.19 09:57, Michal Hocko wrote: >>> On Thu 25-07-19 22:49:36, David Hildenbrand wrote: On 25.07.19 21:19, Michal Hocko wrote: >>> [...] > We need to rationalize the locking here, not to ad

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-26 Thread Michal Hocko
On Fri 26-07-19 10:05:58, David Hildenbrand wrote: > On 26.07.19 09:57, Michal Hocko wrote: > > On Thu 25-07-19 22:49:36, David Hildenbrand wrote: > >> On 25.07.19 21:19, Michal Hocko wrote: > > [...] > >>> We need to rationalize the locking here, not to add more hacks. > >> > >> No, sorry. The rea

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-26 Thread David Hildenbrand
On 26.07.19 09:57, Michal Hocko wrote: > On Thu 25-07-19 22:49:36, David Hildenbrand wrote: >> On 25.07.19 21:19, Michal Hocko wrote: > [...] >>> We need to rationalize the locking here, not to add more hacks. >> >> No, sorry. The real hack is calling a function that is *documented* to >> be called

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-26 Thread Michal Hocko
On Thu 25-07-19 22:49:36, David Hildenbrand wrote: > On 25.07.19 21:19, Michal Hocko wrote: [...] > > We need to rationalize the locking here, not to add more hacks. > > No, sorry. The real hack is calling a function that is *documented* to > be called under lock without it. That is an optimizatio

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-26 Thread David Hildenbrand
On 25.07.19 23:23, Rafael J. Wysocki wrote: > On Thu, Jul 25, 2019 at 10:49 PM David Hildenbrand wrote: >> >> On 25.07.19 21:19, Michal Hocko wrote: >>> On Thu 25-07-19 16:35:07, David Hildenbrand wrote: On 25.07.19 15:57, Michal Hocko wrote: > On Thu 25-07-19 15:05:02, David Hildenbrand

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-25 Thread Rafael J. Wysocki
On Thu, Jul 25, 2019 at 10:49 PM David Hildenbrand wrote: > > On 25.07.19 21:19, Michal Hocko wrote: > > On Thu 25-07-19 16:35:07, David Hildenbrand wrote: > >> On 25.07.19 15:57, Michal Hocko wrote: > >>> On Thu 25-07-19 15:05:02, David Hildenbrand wrote: > On 25.07.19 14:56, Michal Hocko wr

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-25 Thread David Hildenbrand
On 25.07.19 21:19, Michal Hocko wrote: > On Thu 25-07-19 16:35:07, David Hildenbrand wrote: >> On 25.07.19 15:57, Michal Hocko wrote: >>> On Thu 25-07-19 15:05:02, David Hildenbrand wrote: On 25.07.19 14:56, Michal Hocko wrote: > On Wed 24-07-19 16:30:17, David Hildenbrand wrote: >> We

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-25 Thread Michal Hocko
On Thu 25-07-19 16:35:07, David Hildenbrand wrote: > On 25.07.19 15:57, Michal Hocko wrote: > > On Thu 25-07-19 15:05:02, David Hildenbrand wrote: > >> On 25.07.19 14:56, Michal Hocko wrote: > >>> On Wed 24-07-19 16:30:17, David Hildenbrand wrote: > We end up calling __add_memory() without the

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-25 Thread David Hildenbrand
On 25.07.19 15:57, Michal Hocko wrote: > On Thu 25-07-19 15:05:02, David Hildenbrand wrote: >> On 25.07.19 14:56, Michal Hocko wrote: >>> On Wed 24-07-19 16:30:17, David Hildenbrand wrote: We end up calling __add_memory() without the device hotplug lock held. (I used a local patch to asse

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-25 Thread Michal Hocko
On Thu 25-07-19 15:05:02, David Hildenbrand wrote: > On 25.07.19 14:56, Michal Hocko wrote: > > On Wed 24-07-19 16:30:17, David Hildenbrand wrote: > >> We end up calling __add_memory() without the device hotplug lock held. > >> (I used a local patch to assert in __add_memory() that the > >> device

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-25 Thread David Hildenbrand
On 25.07.19 14:56, Michal Hocko wrote: > On Wed 24-07-19 16:30:17, David Hildenbrand wrote: >> We end up calling __add_memory() without the device hotplug lock held. >> (I used a local patch to assert in __add_memory() that the >> device_hotplug_lock is held - I might upstream that as well soon) >

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-25 Thread Michal Hocko
On Wed 24-07-19 16:30:17, David Hildenbrand wrote: > We end up calling __add_memory() without the device hotplug lock held. > (I used a local patch to assert in __add_memory() that the > device_hotplug_lock is held - I might upstream that as well soon) > > [ 26.771684]create_memory_bloc

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-25 Thread David Hildenbrand
On 25.07.19 11:22, Rafael J. Wysocki wrote: > On Thu, Jul 25, 2019 at 11:18 AM Oscar Salvador wrote: >> >> On Wed, Jul 24, 2019 at 04:30:17PM +0200, David Hildenbrand wrote: >>> We end up calling __add_memory() without the device hotplug lock held. >>> (I used a local patch to assert in __add_memo

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-25 Thread Rafael J. Wysocki
On Thu, Jul 25, 2019 at 11:18 AM Oscar Salvador wrote: > > On Wed, Jul 24, 2019 at 04:30:17PM +0200, David Hildenbrand wrote: > > We end up calling __add_memory() without the device hotplug lock held. > > (I used a local patch to assert in __add_memory() that the > > device_hotplug_lock is held -

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-25 Thread Oscar Salvador
On Wed, Jul 24, 2019 at 04:30:17PM +0200, David Hildenbrand wrote: > We end up calling __add_memory() without the device hotplug lock held. > (I used a local patch to assert in __add_memory() that the > device_hotplug_lock is held - I might upstream that as well soon) > > [ 26.771684]cr

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-25 Thread Rafael J. Wysocki
On Wednesday, July 24, 2019 4:30:17 PM CEST David Hildenbrand wrote: > We end up calling __add_memory() without the device hotplug lock held. > (I used a local patch to assert in __add_memory() that the > device_hotplug_lock is held - I might upstream that as well soon) > > [ 26.771684]