Re: [PATCH v1] kdump, vmcoreinfo: report memory sections virtual addresses

2016-09-13 Thread Baoquan He
Hi Thomas, I used below code and it works. Since using VMCOREINFO_NUMBER can reuse the existing struct number_table to import the data. It makes change easier. But the place could be next to KERNEL_IMAGE_SIZE, or as your patch did, both is fine. --- kernel/kexec_core.c | 3 +++ 1 file changed, 3

Re: [PATCH v1] kdump, vmcoreinfo: report memory sections virtual addresses

2016-09-08 Thread Thomas Garnier
On Tue, Sep 6, 2016 at 11:17 PM, Baoquan He wrote: > On 09/07/16 at 03:09pm, AKASHI Takahiro wrote: >> On Mon, Aug 29, 2016 at 06:11:37PM +0800, Baoquan He wrote: >> > Hi Thomas, >> > >> > I used below code and it works. Since using VMCOREINFO_NUMBER can reuse >> > the existing struct number_table

Re: [PATCH v1] kdump, vmcoreinfo: report memory sections virtual addresses

2016-09-06 Thread Baoquan He
On 09/07/16 at 03:09pm, AKASHI Takahiro wrote: > On Mon, Aug 29, 2016 at 06:11:37PM +0800, Baoquan He wrote: > > Hi Thomas, > > > > I used below code and it works. Since using VMCOREINFO_NUMBER can reuse > > the existing struct number_table to import the data. It makes change > > easier. But the p

Re: [PATCH v1] kdump, vmcoreinfo: report memory sections virtual addresses

2016-09-06 Thread AKASHI Takahiro
On Mon, Aug 29, 2016 at 06:11:37PM +0800, Baoquan He wrote: > Hi Thomas, > > I used below code and it works. Since using VMCOREINFO_NUMBER can reuse > the existing struct number_table to import the data. It makes change > easier. But the place could be next to KERNEL_IMAGE_SIZE, or as your > patch

Re: [PATCH v1] kdump, vmcoreinfo: report memory sections virtual addresses

2016-08-29 Thread Thomas Garnier
Great, thanks Baoquan. On Mon, Aug 29, 2016 at 3:11 AM, Baoquan He wrote: > Hi Thomas, > > I used below code and it works. Since using VMCOREINFO_NUMBER can reuse > the existing struct number_table to import the data. It makes change > easier. But the place could be next to KERNEL_IMAGE_SIZE, or

Re: [PATCH v1] kdump, vmcoreinfo: report memory sections virtual addresses

2016-08-29 Thread Baoquan He
Hi Thomas, I used below code and it works. Since using VMCOREINFO_NUMBER can reuse the existing struct number_table to import the data. It makes change easier. But the place could be next to KERNEL_IMAGE_SIZE, or as your patch did, both is fine. --- kernel/kexec_core.c | 3 +++ 1 file changed, 3

Re: [PATCH v1] kdump, vmcoreinfo: report memory sections virtual addresses

2016-08-19 Thread Kees Cook
On Thu, Aug 18, 2016 at 7:41 PM, Baoquan He wrote: > > This makes sense. Makedumpfile need this to parse memory sections. Yup, good addition. Acked-by: Kees Cook -Kees > > Ack. > > Acked-by: Baoquan He > > On 08/18/16 at 07:47am, Thomas Garnier wrote: >> KASLR memory randomization can random

Re: [PATCH v1] kdump, vmcoreinfo: report memory sections virtual addresses

2016-08-18 Thread Baoquan He
This makes sense. Makedumpfile need this to parse memory sections. Ack. Acked-by: Baoquan He On 08/18/16 at 07:47am, Thomas Garnier wrote: > KASLR memory randomization can randomize the base of the physical memory > mapping (PAGE_OFFSET), vmalloc (VMALLOC_START) and vmemmap > (VMEMMAP_START).