Re: [PATCH v1] sched/cfs: Fix pick_next_entity() implementation error

2020-07-01 Thread Zijun Hu
thanks for your explanation. you are right. @lest should be used as reference point to compare. Please ignore this patch. On 7/1/2020 6:47 PM, Vincent Guittot wrote: > On Wed, 1 Jul 2020 at 12:07, Zijun Hu wrote: >> >> sched_entity @se not static @left should be compared >> to pick up @cfs_rq->ne

Re: [PATCH v1] sched/cfs: Fix pick_next_entity() implementation error

2020-07-01 Thread Vincent Guittot
On Wed, 1 Jul 2020 at 12:07, Zijun Hu wrote: > > sched_entity @se not static @left should be compared > to pick up @cfs_rq->next. Could you elaborate why ? left is the leftmost sched_entity and the one that should be used. se != left means that left should be skipped after a yield and the next