Re: [PATCH v1 1/4] platform/x86: intel_pmc_ipc: Use BIT() macro

2019-04-10 Thread sathyanarayanan kuppuswamy
On 4/10/19 6:59 AM, Andy Shevchenko wrote: On Tue, Apr 09, 2019 at 08:39:39PM +0300, Andy Shevchenko wrote: On Tue, Apr 09, 2019 at 10:07:35AM -0700, sathyanarayanan kuppuswamy wrote: On 4/9/19 4:25 AM, Andy Shevchenko wrote: Use BIT() and BIT_MASK() macros for definitions. Looks good to me

Re: [PATCH v1 1/4] platform/x86: intel_pmc_ipc: Use BIT() macro

2019-04-10 Thread Andy Shevchenko
On Tue, Apr 09, 2019 at 08:39:39PM +0300, Andy Shevchenko wrote: > On Tue, Apr 09, 2019 at 10:07:35AM -0700, sathyanarayanan kuppuswamy wrote: > > On 4/9/19 4:25 AM, Andy Shevchenko wrote: > > > Use BIT() and BIT_MASK() macros for definitions. > > Looks good to me. > > Thanks! If you have no furt

Re: [PATCH v1 1/4] platform/x86: intel_pmc_ipc: Use BIT() macro

2019-04-09 Thread Andy Shevchenko
On Tue, Apr 09, 2019 at 10:07:35AM -0700, sathyanarayanan kuppuswamy wrote: > On 4/9/19 4:25 AM, Andy Shevchenko wrote: > > Use BIT() and BIT_MASK() macros for definitions. > Looks good to me. Thanks! > > /* PMC register bit definitions */ > > /* PMC_CFG_REG bit masks */ > > -#define PMC_CFG_