Re: [PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property.

2016-08-22 Thread Mark Rutland
On Fri, Aug 19, 2016 at 09:47:34PM +0100, David Woodhouse wrote: > On Fri, 2016-08-19 at 22:41 +0200, Heiko Stuebner wrote: > > > > > So no, don't *add* any more of these functions. Only add the generic > > > version. And if your driver isn't using the generic property > > > functions... fix it. >

Re: [PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property.

2016-08-22 Thread Finley Xiao
在 2016/8/20 4:47, David Woodhouse 写道: On Fri, 2016-08-19 at 22:41 +0200, Heiko Stuebner wrote: So no, don't *add* any more of these functions. Only add the generic version. And if your driver isn't using the generic property functions... fix it. As far as I can see, all the device_property_*

Re: [PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property.

2016-08-19 Thread David Woodhouse
On Fri, 2016-08-19 at 22:41 +0200, Heiko Stuebner wrote: > > > So no, don't *add* any more of these functions. Only add the generic > > version. And if your driver isn't using the generic property > > functions... fix it. > > As far as I can see, all the device_property_* functions are grounded o

Re: [PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property.

2016-08-19 Thread Heiko Stuebner
Am Freitag, 19. August 2016, 15:15:19 CEST schrieb David Woodhouse: > On Tue, 2016-08-16 at 10:38 +0800, Finlye Xiao wrote: > > From: Finley Xiao > > > > This patch adds an of_property_read_s32_index() function to allow > > reading a single indexed s32 value from a property containing multiple >

Re: [PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property.

2016-08-19 Thread David Woodhouse
On Tue, 2016-08-16 at 10:38 +0800, Finlye Xiao wrote: > From: Finley Xiao > > This patch adds an of_property_read_s32_index() function to allow > reading a single indexed s32 value from a property containing multiple > s32 values. > > Signed-off-by: Finley Xiao NAK. Nobody should be using the

Re: [PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property.

2016-08-16 Thread Heiko Stübner
Hi Finley, Am Dienstag, 16. August 2016, 10:38:58 schrieb Finlye Xiao: > From: Finley Xiao > > This patch adds an of_property_read_s32_index() function to allow > reading a single indexed s32 value from a property containing multiple > s32 values. > > Signed-off-by: Finley Xiao for people read