Re: [PATCH v1 3/6] ASoC: codecs: lpass-wsa-macro: add dapm widgets and route

2020-10-27 Thread Pierre-Louis Bossart
On 10/27/20 5:15 AM, Srinivas Kandagatla wrote: Thanks Pierre for review on all the patches. On 26/10/2020 19:58, Pierre-Louis Bossart wrote: Run cppcheck on this sort of code: cppcheck --platform=unix32 --force --max-configs=1024 --inconclusive --enable=all --suppress=variableScope sound/s

Re: [PATCH v1 3/6] ASoC: codecs: lpass-wsa-macro: add dapm widgets and route

2020-10-27 Thread Srinivas Kandagatla
Thanks Pierre for review on all the patches. On 26/10/2020 19:58, Pierre-Louis Bossart wrote: Run cppcheck on this sort of code: cppcheck --platform=unix32 --force --max-configs=1024 --inconclusive --enable=all --suppress=variableScope sound/soc/codecs/lpass-wsa-macro.c I normally do sparse c

Re: [PATCH v1 3/6] ASoC: codecs: lpass-wsa-macro: add dapm widgets and route

2020-10-26 Thread Pierre-Louis Bossart
+static int wsa_macro_mclk_event(struct snd_soc_dapm_widget *w, + struct snd_kcontrol *kcontrol, int event) +{ + struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); + struct wsa_macro *wsa = snd_soc_component_get_drvdata(component