Re: [PATCH v1 3/7] test_hexdump: go through all possible lengths of buffer

2015-11-26 Thread Andy Shevchenko
On Mon, Nov 23, 2015 at 10:59 AM, Rasmus Villemoes wrote: > On Fri, Nov 20 2015, Andy Shevchenko > wrote: > >> On Thu, 2015-11-19 at 11:07 +0100, Rasmus Villemoes wrote: >>> >>> >>> Why keep the variable l when it is just a synonym for the new >>> parameter buflen? It is quite confusing that you

Re: [PATCH v1 3/7] test_hexdump: go through all possible lengths of buffer

2015-11-23 Thread Rasmus Villemoes
On Fri, Nov 20 2015, Andy Shevchenko wrote: > On Thu, 2015-11-19 at 11:07 +0100, Rasmus Villemoes wrote: >> >> >> Why keep the variable l when it is just a synonym for the new >> parameter buflen? It is quite confusing that you change some but not >> all occurrences of l to buflen. If you want

Re: [PATCH v1 3/7] test_hexdump: go through all possible lengths of buffer

2015-11-20 Thread Andy Shevchenko
On Thu, 2015-11-19 at 11:07 +0100, Rasmus Villemoes wrote: > On Wed, Nov 11 2015, Andy Shevchenko om> wrote: > > > When test for overflow do iterate the buffer length in a range > > 0 .. BUF_SIZE. > > > > Signed-off-by: Andy Shevchenko > > --- > >  lib/test_hexdump.c | 20 ++-- >

Re: [PATCH v1 3/7] test_hexdump: go through all possible lengths of buffer

2015-11-19 Thread Rasmus Villemoes
On Wed, Nov 11 2015, Andy Shevchenko wrote: > When test for overflow do iterate the buffer length in a range > 0 .. BUF_SIZE. > > Signed-off-by: Andy Shevchenko > --- > lib/test_hexdump.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/lib/test_he