Re: [PATCH v1 4/6] block/psi: remove PSI annotations from direct IO

2020-12-22 Thread Christoph Hellwig
I think the commit log could use some rewording with less "as reported" and "apparently". IMHO it is more obvious to just clear the flag in __bio_iov_bvec_add_pages in this patch as well, and just go straight to the rewrite later instead of this intermediate stage.

Re: [PATCH v1 4/6] block/psi: remove PSI annotations from direct IO

2020-12-15 Thread Pavel Begunkov
On 15/12/2020 01:33, Dave Chinner wrote: > On Tue, Dec 15, 2020 at 01:03:45AM +, Pavel Begunkov wrote: >> On 15/12/2020 00:56, Dave Chinner wrote: >>> On Tue, Dec 15, 2020 at 12:20:23AM +, Pavel Begunkov wrote: As reported, we must not do pressure stall information accounting for

Re: [PATCH v1 4/6] block/psi: remove PSI annotations from direct IO

2020-12-14 Thread Dave Chinner
On Tue, Dec 15, 2020 at 01:03:45AM +, Pavel Begunkov wrote: > On 15/12/2020 00:56, Dave Chinner wrote: > > On Tue, Dec 15, 2020 at 12:20:23AM +, Pavel Begunkov wrote: > >> As reported, we must not do pressure stall information accounting for > >> direct IO, because otherwise it tells that

Re: [PATCH v1 4/6] block/psi: remove PSI annotations from direct IO

2020-12-14 Thread Pavel Begunkov
On 15/12/2020 00:56, Dave Chinner wrote: > On Tue, Dec 15, 2020 at 12:20:23AM +, Pavel Begunkov wrote: >> As reported, we must not do pressure stall information accounting for >> direct IO, because otherwise it tells that it's thrashing a page when >> actually doing IO on hot data. >> >>

Re: [PATCH v1 4/6] block/psi: remove PSI annotations from direct IO

2020-12-14 Thread Dave Chinner
On Tue, Dec 15, 2020 at 12:20:23AM +, Pavel Begunkov wrote: > As reported, we must not do pressure stall information accounting for > direct IO, because otherwise it tells that it's thrashing a page when > actually doing IO on hot data. > > Apparently, bio_iov_iter_get_pages() is used only by