Re: [PATCH v1 4/9] blk-mq: introduce init_flush_rq_fn callback in 'blk_mq_ops'

2014-08-17 Thread Jens Axboe
On 2014-08-16 01:49, Ming Lei wrote: On 8/16/14, Jens Axboe wrote: On 08/14/2014 09:50 AM, Ming Lei wrote: Currently pdu of the flush rq is simlpy copied from another rq, it isn't enough to initialize pointer field well, so introduce the callback for driver to handle the case easily. This is

Re: [PATCH v1 4/9] blk-mq: introduce init_flush_rq_fn callback in 'blk_mq_ops'

2014-08-16 Thread Ming Lei
On 8/16/14, Jens Axboe wrote: > On 08/14/2014 09:50 AM, Ming Lei wrote: >> Currently pdu of the flush rq is simlpy copied from another rq, >> it isn't enough to initialize pointer field well, so introduce >> the callback for driver to handle the case easily. > > This is the only patch I don't real

Re: [PATCH v1 4/9] blk-mq: introduce init_flush_rq_fn callback in 'blk_mq_ops'

2014-08-15 Thread Jens Axboe
On 08/14/2014 09:50 AM, Ming Lei wrote: > Currently pdu of the flush rq is simlpy copied from another rq, > it isn't enough to initialize pointer field well, so introduce > the callback for driver to handle the case easily. This is the only patch I don't really like. Can't we make do with calling