Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-28 Thread Dan Carpenter
On Thu, Jan 28, 2021 at 12:32:22AM +0200, Kari Argillander wrote: > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > > @@ -82,6 +111,33 @@ enum st7789v_command { > > */ > > static int init_display(struct fbtft_par *par) > > { > > + int rc; > > + struct device *dev = par->info->devi

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-28 Thread carlis
On Thu, 28 Jan 2021 12:15:28 +0100 Geert Uytterhoeven wrote: > Hi Carlis, > > On Thu, Jan 28, 2021 at 12:03 PM carlis > wrote: > > On Thu, 28 Jan 2021 10:42:54 +0100 > > Geert Uytterhoeven wrote: > > > On Thu, Jan 28, 2021 at 7:53 AM Kari Argillander > > > wrote: > > > > On Thu, Jan 28, 2

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-28 Thread Geert Uytterhoeven
Hi Carlis, On Thu, Jan 28, 2021 at 12:03 PM carlis wrote: > On Thu, 28 Jan 2021 10:42:54 +0100 > Geert Uytterhoeven wrote: > > On Thu, Jan 28, 2021 at 7:53 AM Kari Argillander > > wrote: > > > On Thu, Jan 28, 2021 at 09:42:58AM +0800, carlis wrote: > > > > On Thu, 28 Jan 2021 00:32:22 +0200 > >

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-28 Thread carlis
On Thu, 28 Jan 2021 10:42:54 +0100 Geert Uytterhoeven wrote: > Hi Kari, > > On Thu, Jan 28, 2021 at 7:53 AM Kari Argillander > wrote: > > On Thu, Jan 28, 2021 at 09:42:58AM +0800, carlis wrote: > > > On Thu, 28 Jan 2021 00:32:22 +0200 > > > Kari Argillander wrote: > > > > > #include "fbtf

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-28 Thread Kari Argillander
On Thu, Jan 28, 2021 at 10:42:54AM +0100, Geert Uytterhoeven wrote: > Hi Kari, > > On Thu, Jan 28, 2021 at 7:53 AM Kari Argillander > wrote: > > On Thu, Jan 28, 2021 at 09:42:58AM +0800, carlis wrote: > > > On Thu, 28 Jan 2021 00:32:22 +0200 > > > Kari Argillander wrote: > > > > > @@ -82,6 +111,

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-28 Thread Geert Uytterhoeven
Hi Kari, On Thu, Jan 28, 2021 at 7:53 AM Kari Argillander wrote: > On Thu, Jan 28, 2021 at 09:42:58AM +0800, carlis wrote: > > On Thu, 28 Jan 2021 00:32:22 +0200 > > Kari Argillander wrote: > > > > #include "fbtft.h" > > > > > > > > #define DRVNAME "fb_st7789v" > > > > @@ -66,6 +69,32 @@ enum

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-28 Thread carlis
On Thu, 28 Jan 2021 08:52:33 +0200 Kari Argillander wrote: > On Thu, Jan 28, 2021 at 09:42:58AM +0800, carlis wrote: > > On Thu, 28 Jan 2021 00:32:22 +0200 > > Kari Argillander wrote: > > > > #include "fbtft.h" > > > > > > > > #define DRVNAME "fb_st7789v" > > > > @@ -66,6 +69,32 @@ enum st

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Kari Argillander
On Thu, Jan 28, 2021 at 09:42:58AM +0800, carlis wrote: > On Thu, 28 Jan 2021 00:32:22 +0200 > Kari Argillander wrote: > > > #include "fbtft.h" > > > > > > #define DRVNAME "fb_st7789v" > > > @@ -66,6 +69,32 @@ enum st7789v_command { > > > #define MADCTL_MX BIT(6) /* bitmask for column address

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread carlis
On Thu, 28 Jan 2021 00:32:22 +0200 Kari Argillander wrote: > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > > For st7789v ic,when we need continuous full screen refresh, it is > > best to wait for the TE signal arrive to avoid screen tearing > > > diff --git a/drivers/staging/fbtft

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread carlis
On Wed, 27 Jan 2021 16:02:35 +0100 Greg KH wrote: > On Wed, Jan 27, 2021 at 05:49:46PM +0300, Dan Carpenter wrote: > > On Wed, Jan 27, 2021 at 03:25:20PM +0100, Greg KH wrote: > > > On Wed, Jan 27, 2021 at 10:17:08PM +0800, carlis wrote: > > > > On Wed, 27 Jan 2021 15:13:05 +0100 > > > > Greg

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Kari Argillander
On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > For st7789v ic,when we need continuous full screen refresh, it is best to > wait for the TE signal arrive to avoid screen tearing > diff --git a/drivers/staging/fbtft/fb_st7789v.c > b/drivers/staging/fbtft/fb_st7789v.c > index 3a280cc..cb

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Joe Perches
> Comments are the exception to the "no spaces at the start of a line" > rule. I was expecting that the kbuild-bot would send a Smatch warning > for inconsistent indenting, but comments are not counted there either. > > I'm sort of surprised that we don't have checkpatch rule about the > missing

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Joe Perches
On Wed, 2021-01-27 at 17:49 +0300, Dan Carpenter wrote: > On Wed, Jan 27, 2021 at 03:25:20PM +0100, Greg KH wrote: > > Andy and Joe, there's something wrong here that is missing the fact that > > a line is being indented with spaces and not tabs in the patch > > at > > https://lore.kernel.org/r/1

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 05:49:46PM +0300, Dan Carpenter wrote: > On Wed, Jan 27, 2021 at 03:25:20PM +0100, Greg KH wrote: > > On Wed, Jan 27, 2021 at 10:17:08PM +0800, carlis wrote: > > > On Wed, 27 Jan 2021 15:13:05 +0100 > > > Greg KH wrote: > > > > > > > On Wed, Jan 27, 2021 at 10:08:09PM +080

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Dan Carpenter
On Wed, Jan 27, 2021 at 03:25:20PM +0100, Greg KH wrote: > On Wed, Jan 27, 2021 at 10:17:08PM +0800, carlis wrote: > > On Wed, 27 Jan 2021 15:13:05 +0100 > > Greg KH wrote: > > > > > On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote: > > > > On Wed, 27 Jan 2021 14:51:55 +0100 > > > > Greg KH

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 10:17:08PM +0800, carlis wrote: > On Wed, 27 Jan 2021 15:13:05 +0100 > Greg KH wrote: > > > On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote: > > > On Wed, 27 Jan 2021 14:51:55 +0100 > > > Greg KH wrote: > > > > > > > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Car

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread carlis
On Wed, 27 Jan 2021 15:13:05 +0100 Greg KH wrote: > On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote: > > On Wed, 27 Jan 2021 14:51:55 +0100 > > Greg KH wrote: > > > > > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > > > > From: zhangxuezhi > > > > > > > > For st7789v ic,

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote: > On Wed, 27 Jan 2021 14:51:55 +0100 > Greg KH wrote: > > > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > > > From: zhangxuezhi > > > > > > For st7789v ic,when we need continuous full screen refresh, it is > > > best to wait fo

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread carlis
On Wed, 27 Jan 2021 14:51:55 +0100 Greg KH wrote: > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > > From: zhangxuezhi > > > > For st7789v ic,when we need continuous full screen refresh, it is > > best to wait for the TE signal arrive to avoid screen tearing > > > > Signed-off-by: z

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > From: zhangxuezhi > > For st7789v ic,when we need continuous full screen refresh, it is best to > wait for the TE signal arrive to avoid screen tearing > > Signed-off-by: zhangxuezhi Please slow down and wait at least a day between patc