Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-25 Thread David Hildenbrand
On 25/09/2018 21:54, Tony Krowiak wrote: > On 09/24/2018 03:55 PM, David Hildenbrand wrote: >> On 24/09/2018 21:46, Tony Krowiak wrote: >>> On 09/24/2018 02:40 PM, David Hildenbrand wrote: On 24/09/2018 18:07, Tony Krowiak wrote: > On 09/24/2018 04:40 AM, David Hildenbrand wrote: >> >>

Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-25 Thread Tony Krowiak
On 09/24/2018 03:55 PM, David Hildenbrand wrote: On 24/09/2018 21:46, Tony Krowiak wrote: On 09/24/2018 02:40 PM, David Hildenbrand wrote: On 24/09/2018 18:07, Tony Krowiak wrote: On 09/24/2018 04:40 AM, David Hildenbrand wrote: /** - * Verify that the AP instructions are available on

Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-24 Thread David Hildenbrand
On 24/09/2018 21:46, Tony Krowiak wrote: > On 09/24/2018 02:40 PM, David Hildenbrand wrote: >> On 24/09/2018 18:07, Tony Krowiak wrote: >>> On 09/24/2018 04:40 AM, David Hildenbrand wrote: > /** > - * Verify that the AP instructions are available on the guest. This is > indicat

Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-24 Thread Tony Krowiak
On 09/24/2018 02:40 PM, David Hildenbrand wrote: On 24/09/2018 18:07, Tony Krowiak wrote: On 09/24/2018 04:40 AM, David Hildenbrand wrote: /** - * Verify that the AP instructions are available on the guest. This is indicated - * via the KVM_S390_VM_CPU_FEAT_AP CPU model feature. + * Veri

Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-24 Thread Tony Krowiak
On 09/24/2018 02:40 PM, David Hildenbrand wrote: On 24/09/2018 18:07, Tony Krowiak wrote: On 09/24/2018 04:40 AM, David Hildenbrand wrote: /** - * Verify that the AP instructions are available on the guest. This is indicated - * via the KVM_S390_VM_CPU_FEAT_AP CPU model feature. + * Veri

Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-24 Thread David Hildenbrand
On 24/09/2018 18:07, Tony Krowiak wrote: > On 09/24/2018 04:40 AM, David Hildenbrand wrote: >> >>>/** >>> - * Verify that the AP instructions are available on the guest. This is >>> indicated >>> - * via the KVM_S390_VM_CPU_FEAT_AP CPU model feature. >>> + * Verify that the AP instructions are

Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-24 Thread Tony Krowiak
On 09/24/2018 04:40 AM, David Hildenbrand wrote: /** - * Verify that the AP instructions are available on the guest. This is indicated - * via the KVM_S390_VM_CPU_FEAT_AP CPU model feature. + * Verify that the AP instructions are being interpreted by firmware for the + * guest. This is indi

Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-24 Thread David Hildenbrand
> /** > - * Verify that the AP instructions are available on the guest. This is > indicated > - * via the KVM_S390_VM_CPU_FEAT_AP CPU model feature. > + * Verify that the AP instructions are being interpreted by firmware > for the > + * guest. This is indicated by the kvm->arch.crypto.apie f

Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-21 Thread Tony Krowiak
On 09/12/2018 03:43 PM, Tony Krowiak wrote: From: Tony Krowiak Implements the open callback on the mediated matrix device. The function registers a group notifier to receive notification of the VFIO_GROUP_NOTIFY_SET_KVM event. When notified, the vfio_ap device driver will get access to the gues

Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-18 Thread Tony Krowiak
On 09/18/2018 01:00 PM, Halil Pasic wrote: On 09/12/2018 09:43 PM, Tony Krowiak wrote: +/** + * vfio_ap_mdev_open_once + * + * @matrix_mdev: a mediated matrix device + * + * Return 0 if no other mediated matrix device has been opened for the + * KVM guest assigned to @matrix_mdev; otherwise, re

Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-18 Thread Halil Pasic
On 09/12/2018 09:43 PM, Tony Krowiak wrote: > +/** > + * vfio_ap_mdev_open_once > + * > + * @matrix_mdev: a mediated matrix device > + * > + * Return 0 if no other mediated matrix device has been opened for the > + * KVM guest assigned to @matrix_mdev; otherwise, returns an error. > + */ > +stat