Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-30 Thread Peter Hurley
On 01/30/2015 10:49 AM, Russell King - ARM Linux wrote: > On Fri, Jan 30, 2015 at 10:32:54AM -0500, Peter Hurley wrote: >> Before you say consistency, I think you should look at the stats below. >> IOW, if you want to change the error code return from probe() for >> consistency's sake, a tree-wide

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-30 Thread Russell King - ARM Linux
On Fri, Jan 30, 2015 at 10:32:54AM -0500, Peter Hurley wrote: > Before you say consistency, I think you should look at the stats below. > IOW, if you want to change the error code return from probe() for > consistency's sake, a tree-wide patch would be the appropriate way. Now look outside the ser

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-30 Thread Peter Hurley
On 01/30/2015 09:08 AM, Russell King - ARM Linux wrote: > On Fri, Jan 30, 2015 at 07:03:03AM -0500, Peter Hurley wrote: >> On 01/30/2015 05:18 AM, Thierry Reding wrote: >>> -ENODEV is certainly not the correct return value if a resource is not >>> available. It translates to "no such device", but t

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-30 Thread Russell King - ARM Linux
On Fri, Jan 30, 2015 at 07:03:03AM -0500, Peter Hurley wrote: > On 01/30/2015 05:18 AM, Thierry Reding wrote: > > -ENODEV is certainly not the correct return value if a resource is not > > available. It translates to "no such device", but the device must > > clearly be there, otherwise the ->probe(

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-30 Thread Peter Hurley
On 01/30/2015 05:18 AM, Thierry Reding wrote: > On Thu, Jan 29, 2015 at 04:05:53PM +, Russell King - ARM Linux wrote: >> On Thu, Jan 29, 2015 at 10:49:34AM -0500, Peter Hurley wrote: >>> Hi Varka, >>> >>> On 01/29/2015 10:26 AM, Varka Bhadram wrote: This check is not required. It will be d

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-30 Thread Thierry Reding
On Thu, Jan 29, 2015 at 04:05:53PM +, Russell King - ARM Linux wrote: > On Thu, Jan 29, 2015 at 10:49:34AM -0500, Peter Hurley wrote: > > Hi Varka, > > > > On 01/29/2015 10:26 AM, Varka Bhadram wrote: > > > This check is not required. It will be done by devm_ioremap_resource() > > > > I disag

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-29 Thread Peter Hurley
On 01/29/2015 11:05 AM, Russell King - ARM Linux wrote: > On Thu, Jan 29, 2015 at 10:49:34AM -0500, Peter Hurley wrote: >> Hi Varka, >> >> On 01/29/2015 10:26 AM, Varka Bhadram wrote: >>> This check is not required. It will be done by devm_ioremap_resource() >> >> I disagree. devm_ioremap_resource(

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-29 Thread Peter Hurley
On 01/29/2015 11:04 AM, Varka Bhadram wrote: > Hi Peter, > > On Thursday 29 January 2015 09:19 PM, Peter Hurley wrote: >> Hi Varka, >> >> On 01/29/2015 10:26 AM, Varka Bhadram wrote: >>> Hi, >>> >>> On Wednesday 28 January 2015 04:38 PM, Chunyan Zhang wrote: Add a full sc9836-uart driver for

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-29 Thread Russell King - ARM Linux
On Thu, Jan 29, 2015 at 10:49:34AM -0500, Peter Hurley wrote: > Hi Varka, > > On 01/29/2015 10:26 AM, Varka Bhadram wrote: > > This check is not required. It will be done by devm_ioremap_resource() > > I disagree. devm_ioremap_resource() interprets the NULL resource as > a bad parameter and retur

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-29 Thread Peter Hurley
Hi Varka, On 01/29/2015 10:26 AM, Varka Bhadram wrote: > Hi, > > On Wednesday 28 January 2015 04:38 PM, Chunyan Zhang wrote: >> Add a full sc9836-uart driver for SC9836 SoC which is based on the >> spreadtrum sharkl64 platform. >> This driver also support earlycon. >> >> Originally-by: Lanqing Li

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-29 Thread Varka Bhadram
On Thursday 29 January 2015 08:56 PM, Varka Bhadram wrote: Hi, On Wednesday 28 January 2015 04:38 PM, Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. Originally-by: Lanqing Liu Signed-off-

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-29 Thread Varka Bhadram
Hi, On Wednesday 28 January 2015 04:38 PM, Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. Originally-by: Lanqing Liu Signed-off-by: Orson Zhai Signed-off-by: Chunyan Zhang Acked-by: Arnd