Re: [PATCH v10 20/22] x86: mm: Convert dump_pagetables to use walk_page_range

2019-08-07 Thread Andrew Morton
On Wed, 7 Aug 2019 13:58:21 +0100 Steven Price wrote: > > ./arch/x86/include/asm/pgtable_64_types.h:56:22: error: initializer element > > is not constant > > #define PTRS_PER_PGD 512 > > ^ > > This is very unhelpful of GCC - it's actually PTRS_PER_P4D which isn't > consta

Re: [PATCH v10 20/22] x86: mm: Convert dump_pagetables to use walk_page_range

2019-08-07 Thread Steven Price
On 07/08/2019 00:58, Andrew Morton wrote: > On Wed, 31 Jul 2019 16:46:01 +0100 Steven Price wrote: > >> Make use of the new functionality in walk_page_range to remove the >> arch page walking code and use the generic code to walk the page tables. >> >> The effective permissions are passed down th

Re: [PATCH v10 20/22] x86: mm: Convert dump_pagetables to use walk_page_range

2019-08-06 Thread Andrew Morton
On Wed, 31 Jul 2019 16:46:01 +0100 Steven Price wrote: > Make use of the new functionality in walk_page_range to remove the > arch page walking code and use the generic code to walk the page tables. > > The effective permissions are passed down the chain using new fields > in struct pg_state. >